lubiana/futtern
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 32 Packages Wiki Activity Actions

make aliases work #73

Merged
lubiana merged 1 commit from bugfixes_menuitem_aliases into main 2025-01-25 17:13:31 +00:00
Conversation 1 Commits 1 Files changed 2 +29 -15
lubiana commented 2025-01-25 17:07:57 +00:00
Owner
Copy link
No description provided.
lubiana added 1 commit 2025-01-25 17:07:58 +00:00
make aliases work
All checks were successful
/ ls (pull_request) Successful in 2m37s
Details
/ ls (push) Successful in 2m41s
Details
232878ebfb
forgejo-actions commented 2025-01-25 17:10:19 +00:00
First-time contributor
Copy link
Escaped mutants:
================

Timed Out mutants:
==================

Skipped mutants:
================

Not Covered mutants:
====================

1) /workspace/lubiana/futtern/src/Controller/MenuItemController.php:33    [M] MethodCallRemoval

@@ @@
         if ($form->isSubmitted() && $form->isValid()) {
             foreach ($menuItem->getFoodVendor()->getMenuItems() as $vendorItem) {
                 if ($menuItem->getAliases()->contains($vendorItem)) {
-                    $vendorItem->setAliasOf($menuItem);
+                    
                 } elseif ($vendorItem->getAliasOf() === $menuItem) {
                     $vendorItem->setAliasOf(null);
                 }


2) /workspace/lubiana/futtern/src/Controller/MenuItemController.php:35    [M] MethodCallRemoval

@@ @@
                 if ($menuItem->getAliases()->contains($vendorItem)) {
                     $vendorItem->setAliasOf($menuItem);
                 } elseif ($vendorItem->getAliasOf() === $menuItem) {
-                    $vendorItem->setAliasOf(null);
+                    
                 }
                 $entityManager->persist($vendorItem);
             }


3) /workspace/lubiana/futtern/src/Controller/OrderItemController.php:50    [M] MethodCallRemoval

@@ @@
             }
             if ($menuItem->getAliasOf() !== null) {
                 $menuItem = $menuItem->getAliasOf();
-                $orderItem->setName($menuItem->getName());
+                
             }
             $orderItem->setMenuItem($menuItem);
             $orderItem->setFoodOrder($foodOrder);


4) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:22    [M] MethodCallRemoval

@@ @@
     {
         $this->manager = $manager;
         $vendorA = $this->createVendor('Vendor A');
-        $this->addMenuItemsToVendor($vendorA);
+        
         $vendorB = $this->createVendor('Vendor B');
         $this->addMenuItemsToVendor($vendorB);
     }


5) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:25    [M] MethodCallRemoval

@@ @@
         $vendorA = $this->createVendor('Vendor A');
         $this->addMenuItemsToVendor($vendorA);
         $vendorB = $this->createVendor('Vendor B');
-        $this->addMenuItemsToVendor($vendorB);
+        
     }
     public function createVendor(string $name): FoodVendor
     {


6) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:28    [M] PublicVisibility

@@ @@
         $vendorB = $this->createVendor('Vendor B');
         $this->addMenuItemsToVendor($vendorB);
     }
-    public function createVendor(string $name): FoodVendor
+    protected function createVendor(string $name): FoodVendor
     {
         $vendorA = new FoodVendor();
         $vendorA->setName($name);


7) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:31    [M] MethodCallRemoval

@@ @@
     public function createVendor(string $name): FoodVendor
     {
         $vendorA = new FoodVendor();
-        $vendorA->setName($name);
+        
         $vendorA->setMenuLink('https://vendora.com');
         $vendorA->setPhone('1234567890');
         $this->manager->persist($vendorA);


8) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:32    [M] MethodCallRemoval

@@ @@
     {
         $vendorA = new FoodVendor();
         $vendorA->setName($name);
-        $vendorA->setMenuLink('https://vendora.com');
+        
         $vendorA->setPhone('1234567890');
         $this->manager->persist($vendorA);
         $this->manager->flush();


9) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:33    [M] MethodCallRemoval

@@ @@
         $vendorA = new FoodVendor();
         $vendorA->setName($name);
         $vendorA->setMenuLink('https://vendora.com');
-        $vendorA->setPhone('1234567890');
+        
         $this->manager->persist($vendorA);
         $this->manager->flush();
         return $vendorA;


10) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:35    [M] MethodCallRemoval

@@ @@
         $vendorA->setName($name);
         $vendorA->setMenuLink('https://vendora.com');
         $vendorA->setPhone('1234567890');
-        $this->manager->persist($vendorA);
+        
         $this->manager->flush();
         return $vendorA;
     }


11) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:36    [M] MethodCallRemoval

@@ @@
         $vendorA->setMenuLink('https://vendora.com');
         $vendorA->setPhone('1234567890');
         $this->manager->persist($vendorA);
-        $this->manager->flush();
+        
         return $vendorA;
     }
     public function addMenuItemsToVendor(FoodVendor $vendor): void


12) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:40    [M] PublicVisibility

@@ @@
         $this->manager->flush();
         return $vendorA;
     }
-    public function addMenuItemsToVendor(FoodVendor $vendor): void
+    protected function addMenuItemsToVendor(FoodVendor $vendor): void
     {
         foreach (range(1, 10) as $i) {
             $item = new MenuItem();


13) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42    [M] DecrementInteger

@@ @@
     }
     public function addMenuItemsToVendor(FoodVendor $vendor): void
     {
-        foreach (range(1, 10) as $i) {
+        foreach (range(0, 10) as $i) {
             $item = new MenuItem();
             $item->setName("{$vendor->getName()} Item {$i}");
             $item->setFoodVendor($vendor);


14) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42    [M] IncrementInteger

@@ @@
     }
     public function addMenuItemsToVendor(FoodVendor $vendor): void
     {
-        foreach (range(1, 10) as $i) {
+        foreach (range(2, 10) as $i) {
             $item = new MenuItem();
             $item->setName("{$vendor->getName()} Item {$i}");
             $item->setFoodVendor($vendor);


15) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42    [M] DecrementInteger

@@ @@
     }
     public function addMenuItemsToVendor(FoodVendor $vendor): void
     {
-        foreach (range(1, 10) as $i) {
+        foreach (range(1, 9) as $i) {
             $item = new MenuItem();
             $item->setName("{$vendor->getName()} Item {$i}");
             $item->setFoodVendor($vendor);


16) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42    [M] IncrementInteger

@@ @@
     }
     public function addMenuItemsToVendor(FoodVendor $vendor): void
     {
-        foreach (range(1, 10) as $i) {
+        foreach (range(1, 11) as $i) {
             $item = new MenuItem();
             $item->setName("{$vendor->getName()} Item {$i}");
             $item->setFoodVendor($vendor);


17) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42    [M] Foreach_

@@ @@
     }
     public function addMenuItemsToVendor(FoodVendor $vendor): void
     {
-        foreach (range(1, 10) as $i) {
+        foreach ([] as $i) {
             $item = new MenuItem();
             $item->setName("{$vendor->getName()} Item {$i}");
             $item->setFoodVendor($vendor);


18) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:44    [M] MethodCallRemoval

@@ @@
     {
         foreach (range(1, 10) as $i) {
             $item = new MenuItem();
-            $item->setName("{$vendor->getName()} Item {$i}");
+            
             $item->setFoodVendor($vendor);
             $this->manager->persist($item);
             $this->manager->flush();


19) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:45    [M] MethodCallRemoval

@@ @@
         foreach (range(1, 10) as $i) {
             $item = new MenuItem();
             $item->setName("{$vendor->getName()} Item {$i}");
-            $item->setFoodVendor($vendor);
+            
             $this->manager->persist($item);
             $this->manager->flush();
         }
     }
 }


20) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:46    [M] MethodCallRemoval

@@ @@
             $item = new MenuItem();
             $item->setName("{$vendor->getName()} Item {$i}");
             $item->setFoodVendor($vendor);
-            $this->manager->persist($item);
+            
             $this->manager->flush();
         }
     }
 }


21) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:47    [M] MethodCallRemoval

@@ @@
             $item->setName("{$vendor->getName()} Item {$i}");
             $item->setFoodVendor($vendor);
             $this->manager->persist($item);
-            $this->manager->flush();
+            
         }
     }
 }


22) /workspace/lubiana/futtern/src/Entity/MenuItem.php:103    [M] PublicVisibility

@@ @@
     {
         return $this->aliasOf;
     }
-    public function setAliasOf(self|null $aliasOf): static
+    protected function setAliasOf(self|null $aliasOf): static
     {
         $this->aliasOf = $aliasOf;
         return $this;


23) /workspace/lubiana/futtern/src/Entity/MenuItem.php:118    [M] PublicVisibility

@@ @@
     {
         return $this->aliases;
     }
-    public function addAlias(self $alias): static
+    protected function addAlias(self $alias): static
     {
         if (!$this->aliases->contains($alias)) {
             $this->aliases->add($alias);


24) /workspace/lubiana/futtern/src/Entity/MenuItem.php:120    [M] LogicalNot

@@ @@
     }
     public function addAlias(self $alias): static
     {
-        if (!$this->aliases->contains($alias)) {
+        if ($this->aliases->contains($alias)) {
             $this->aliases->add($alias);
             $alias->setAliasOf($this);
         }


25) /workspace/lubiana/futtern/src/Entity/MenuItem.php:121    [M] MethodCallRemoval

@@ @@
     public function addAlias(self $alias): static
     {
         if (!$this->aliases->contains($alias)) {
-            $this->aliases->add($alias);
+            
             $alias->setAliasOf($this);
         }
         return $this;


26) /workspace/lubiana/futtern/src/Entity/MenuItem.php:122    [M] MethodCallRemoval

@@ @@
     {
         if (!$this->aliases->contains($alias)) {
             $this->aliases->add($alias);
-            $alias->setAliasOf($this);
+            
         }
         return $this;
     }


27) /workspace/lubiana/futtern/src/Entity/MenuItem.php:128    [M] PublicVisibility

@@ @@
         }
         return $this;
     }
-    public function removeAlias(self $alias): static
+    protected function removeAlias(self $alias): static
     {
         // set the owning side to null (unless already changed)
         if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {


28) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131    [M] Identical

@@ @@
     public function removeAlias(self $alias): static
     {
         // set the owning side to null (unless already changed)
-        if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {
+        if ($this->aliases->removeElement($alias) && $alias->getAliasOf() !== $this) {
             $alias->setAliasOf(null);
         }
         return $this;
     }
 }


29) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131    [M] LogicalAnd

@@ @@
     public function removeAlias(self $alias): static
     {
         // set the owning side to null (unless already changed)
-        if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {
+        if ($this->aliases->removeElement($alias) || $alias->getAliasOf() === $this) {
             $alias->setAliasOf(null);
         }
         return $this;
     }
 }


30) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131    [M] LogicalAndAllSubExprNegation

@@ @@
     public function removeAlias(self $alias): static
     {
         // set the owning side to null (unless already changed)
-        if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {
+        if (!$this->aliases->removeElement($alias) && !($alias->getAliasOf() === $this)) {
             $alias->setAliasOf(null);
         }
         return $this;
     }
 }


31) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131    [M] LogicalAndNegation

@@ @@
     public function removeAlias(self $alias): static
     {
         // set the owning side to null (unless already changed)
-        if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {
+        if (!($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this)) {
             $alias->setAliasOf(null);
         }
         return $this;
     }
 }


32) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131    [M] LogicalAndSingleSubExprNegation

@@ @@
     public function removeAlias(self $alias): static
     {
         // set the owning side to null (unless already changed)
-        if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {
+        if (!$this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {
             $alias->setAliasOf(null);
         }
         return $this;
     }
 }


33) /workspace/lubiana/futtern/src/Entity/MenuItem.php:132    [M] MethodCallRemoval

@@ @@
     {
         // set the owning side to null (unless already changed)
         if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) {
-            $alias->setAliasOf(null);
+            
         }
         return $this;
     }
 }
Total: 371

Killed: 338
Errored: 0
Syntax Errors: 0
Escaped: 0
Timed Out: 0
Skipped: 0
Ignored: 0
Not Covered: 33
``` Escaped mutants: ================ Timed Out mutants: ================== Skipped mutants: ================ Not Covered mutants: ==================== 1) /workspace/lubiana/futtern/src/Controller/MenuItemController.php:33 [M] MethodCallRemoval @@ @@ if ($form->isSubmitted() && $form->isValid()) { foreach ($menuItem->getFoodVendor()->getMenuItems() as $vendorItem) { if ($menuItem->getAliases()->contains($vendorItem)) { - $vendorItem->setAliasOf($menuItem); + } elseif ($vendorItem->getAliasOf() === $menuItem) { $vendorItem->setAliasOf(null); } 2) /workspace/lubiana/futtern/src/Controller/MenuItemController.php:35 [M] MethodCallRemoval @@ @@ if ($menuItem->getAliases()->contains($vendorItem)) { $vendorItem->setAliasOf($menuItem); } elseif ($vendorItem->getAliasOf() === $menuItem) { - $vendorItem->setAliasOf(null); + } $entityManager->persist($vendorItem); } 3) /workspace/lubiana/futtern/src/Controller/OrderItemController.php:50 [M] MethodCallRemoval @@ @@ } if ($menuItem->getAliasOf() !== null) { $menuItem = $menuItem->getAliasOf(); - $orderItem->setName($menuItem->getName()); + } $orderItem->setMenuItem($menuItem); $orderItem->setFoodOrder($foodOrder); 4) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:22 [M] MethodCallRemoval @@ @@ { $this->manager = $manager; $vendorA = $this->createVendor('Vendor A'); - $this->addMenuItemsToVendor($vendorA); + $vendorB = $this->createVendor('Vendor B'); $this->addMenuItemsToVendor($vendorB); } 5) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:25 [M] MethodCallRemoval @@ @@ $vendorA = $this->createVendor('Vendor A'); $this->addMenuItemsToVendor($vendorA); $vendorB = $this->createVendor('Vendor B'); - $this->addMenuItemsToVendor($vendorB); + } public function createVendor(string $name): FoodVendor { 6) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:28 [M] PublicVisibility @@ @@ $vendorB = $this->createVendor('Vendor B'); $this->addMenuItemsToVendor($vendorB); } - public function createVendor(string $name): FoodVendor + protected function createVendor(string $name): FoodVendor { $vendorA = new FoodVendor(); $vendorA->setName($name); 7) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:31 [M] MethodCallRemoval @@ @@ public function createVendor(string $name): FoodVendor { $vendorA = new FoodVendor(); - $vendorA->setName($name); + $vendorA->setMenuLink('https://vendora.com'); $vendorA->setPhone('1234567890'); $this->manager->persist($vendorA); 8) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:32 [M] MethodCallRemoval @@ @@ { $vendorA = new FoodVendor(); $vendorA->setName($name); - $vendorA->setMenuLink('https://vendora.com'); + $vendorA->setPhone('1234567890'); $this->manager->persist($vendorA); $this->manager->flush(); 9) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:33 [M] MethodCallRemoval @@ @@ $vendorA = new FoodVendor(); $vendorA->setName($name); $vendorA->setMenuLink('https://vendora.com'); - $vendorA->setPhone('1234567890'); + $this->manager->persist($vendorA); $this->manager->flush(); return $vendorA; 10) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:35 [M] MethodCallRemoval @@ @@ $vendorA->setName($name); $vendorA->setMenuLink('https://vendora.com'); $vendorA->setPhone('1234567890'); - $this->manager->persist($vendorA); + $this->manager->flush(); return $vendorA; } 11) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:36 [M] MethodCallRemoval @@ @@ $vendorA->setMenuLink('https://vendora.com'); $vendorA->setPhone('1234567890'); $this->manager->persist($vendorA); - $this->manager->flush(); + return $vendorA; } public function addMenuItemsToVendor(FoodVendor $vendor): void 12) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:40 [M] PublicVisibility @@ @@ $this->manager->flush(); return $vendorA; } - public function addMenuItemsToVendor(FoodVendor $vendor): void + protected function addMenuItemsToVendor(FoodVendor $vendor): void { foreach (range(1, 10) as $i) { $item = new MenuItem(); 13) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42 [M] DecrementInteger @@ @@ } public function addMenuItemsToVendor(FoodVendor $vendor): void { - foreach (range(1, 10) as $i) { + foreach (range(0, 10) as $i) { $item = new MenuItem(); $item->setName("{$vendor->getName()} Item {$i}"); $item->setFoodVendor($vendor); 14) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42 [M] IncrementInteger @@ @@ } public function addMenuItemsToVendor(FoodVendor $vendor): void { - foreach (range(1, 10) as $i) { + foreach (range(2, 10) as $i) { $item = new MenuItem(); $item->setName("{$vendor->getName()} Item {$i}"); $item->setFoodVendor($vendor); 15) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42 [M] DecrementInteger @@ @@ } public function addMenuItemsToVendor(FoodVendor $vendor): void { - foreach (range(1, 10) as $i) { + foreach (range(1, 9) as $i) { $item = new MenuItem(); $item->setName("{$vendor->getName()} Item {$i}"); $item->setFoodVendor($vendor); 16) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42 [M] IncrementInteger @@ @@ } public function addMenuItemsToVendor(FoodVendor $vendor): void { - foreach (range(1, 10) as $i) { + foreach (range(1, 11) as $i) { $item = new MenuItem(); $item->setName("{$vendor->getName()} Item {$i}"); $item->setFoodVendor($vendor); 17) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:42 [M] Foreach_ @@ @@ } public function addMenuItemsToVendor(FoodVendor $vendor): void { - foreach (range(1, 10) as $i) { + foreach ([] as $i) { $item = new MenuItem(); $item->setName("{$vendor->getName()} Item {$i}"); $item->setFoodVendor($vendor); 18) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:44 [M] MethodCallRemoval @@ @@ { foreach (range(1, 10) as $i) { $item = new MenuItem(); - $item->setName("{$vendor->getName()} Item {$i}"); + $item->setFoodVendor($vendor); $this->manager->persist($item); $this->manager->flush(); 19) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:45 [M] MethodCallRemoval @@ @@ foreach (range(1, 10) as $i) { $item = new MenuItem(); $item->setName("{$vendor->getName()} Item {$i}"); - $item->setFoodVendor($vendor); + $this->manager->persist($item); $this->manager->flush(); } } } 20) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:46 [M] MethodCallRemoval @@ @@ $item = new MenuItem(); $item->setName("{$vendor->getName()} Item {$i}"); $item->setFoodVendor($vendor); - $this->manager->persist($item); + $this->manager->flush(); } } } 21) /workspace/lubiana/futtern/src/DataFixtures/AppFixtures.php:47 [M] MethodCallRemoval @@ @@ $item->setName("{$vendor->getName()} Item {$i}"); $item->setFoodVendor($vendor); $this->manager->persist($item); - $this->manager->flush(); + } } } 22) /workspace/lubiana/futtern/src/Entity/MenuItem.php:103 [M] PublicVisibility @@ @@ { return $this->aliasOf; } - public function setAliasOf(self|null $aliasOf): static + protected function setAliasOf(self|null $aliasOf): static { $this->aliasOf = $aliasOf; return $this; 23) /workspace/lubiana/futtern/src/Entity/MenuItem.php:118 [M] PublicVisibility @@ @@ { return $this->aliases; } - public function addAlias(self $alias): static + protected function addAlias(self $alias): static { if (!$this->aliases->contains($alias)) { $this->aliases->add($alias); 24) /workspace/lubiana/futtern/src/Entity/MenuItem.php:120 [M] LogicalNot @@ @@ } public function addAlias(self $alias): static { - if (!$this->aliases->contains($alias)) { + if ($this->aliases->contains($alias)) { $this->aliases->add($alias); $alias->setAliasOf($this); } 25) /workspace/lubiana/futtern/src/Entity/MenuItem.php:121 [M] MethodCallRemoval @@ @@ public function addAlias(self $alias): static { if (!$this->aliases->contains($alias)) { - $this->aliases->add($alias); + $alias->setAliasOf($this); } return $this; 26) /workspace/lubiana/futtern/src/Entity/MenuItem.php:122 [M] MethodCallRemoval @@ @@ { if (!$this->aliases->contains($alias)) { $this->aliases->add($alias); - $alias->setAliasOf($this); + } return $this; } 27) /workspace/lubiana/futtern/src/Entity/MenuItem.php:128 [M] PublicVisibility @@ @@ } return $this; } - public function removeAlias(self $alias): static + protected function removeAlias(self $alias): static { // set the owning side to null (unless already changed) if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { 28) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131 [M] Identical @@ @@ public function removeAlias(self $alias): static { // set the owning side to null (unless already changed) - if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { + if ($this->aliases->removeElement($alias) && $alias->getAliasOf() !== $this) { $alias->setAliasOf(null); } return $this; } } 29) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131 [M] LogicalAnd @@ @@ public function removeAlias(self $alias): static { // set the owning side to null (unless already changed) - if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { + if ($this->aliases->removeElement($alias) || $alias->getAliasOf() === $this) { $alias->setAliasOf(null); } return $this; } } 30) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131 [M] LogicalAndAllSubExprNegation @@ @@ public function removeAlias(self $alias): static { // set the owning side to null (unless already changed) - if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { + if (!$this->aliases->removeElement($alias) && !($alias->getAliasOf() === $this)) { $alias->setAliasOf(null); } return $this; } } 31) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131 [M] LogicalAndNegation @@ @@ public function removeAlias(self $alias): static { // set the owning side to null (unless already changed) - if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { + if (!($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this)) { $alias->setAliasOf(null); } return $this; } } 32) /workspace/lubiana/futtern/src/Entity/MenuItem.php:131 [M] LogicalAndSingleSubExprNegation @@ @@ public function removeAlias(self $alias): static { // set the owning side to null (unless already changed) - if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { + if (!$this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { $alias->setAliasOf(null); } return $this; } } 33) /workspace/lubiana/futtern/src/Entity/MenuItem.php:132 [M] MethodCallRemoval @@ @@ { // set the owning side to null (unless already changed) if ($this->aliases->removeElement($alias) && $alias->getAliasOf() === $this) { - $alias->setAliasOf(null); + } return $this; } } Total: 371 Killed: 338 Errored: 0 Syntax Errors: 0 Escaped: 0 Timed Out: 0 Skipped: 0 Ignored: 0 Not Covered: 33 ```
lubiana merged commit 232878ebfb into main 2025-01-25 17:13:31 +00:00
lubiana deleted branch bugfixes_menuitem_aliases 2025-01-25 17:13:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lubiana/futtern#73
No description provided.
Delete branch "bugfixes_menuitem_aliases"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?