c3lf/c3lf-system-3
9
0
Fork 0
Code Issues 66 Pull requests 1 Projects 2 Releases Wiki Activity Actions

metrics: Make metrics actually usable #104

Merged
lagertonne merged 2 commits from lagertonne/more-metrics-2 into testing 2024-12-23 13:20:45 +00:00
Conversation 1 Commits 2 Files changed 2 +37
lagertonne commented 2024-12-21 21:17:38 +00:00
Owner
Copy link

Somehow, the metrics weren't actually updated when using the workaround with the command. I guess something is going on with django-prometheus and the prometheus_client module.

This fix has another approach: The gauge is now updated on every request. This could potentially be a performance issue, but count-commands should be fast enough from the db side, and we limit who can access the endpoint.

Also, it counts all the objects.

Somehow, the metrics weren't actually updated when using the workaround with the command. I guess something is going on with django-prometheus and the prometheus_client module. This fix has another approach: The gauge is now updated on every request. This could potentially be a performance issue, but count-commands should be fast enough from the db side, and we limit who can access the endpoint. Also, it counts *all* the objects.
lagertonne added 1 commit 2024-12-21 21:17:38 +00:00
metrics: Make metrics actually usable
All checks were successful
/ test (push) Successful in 2m52s
Details
/ test (pull_request) Successful in 2m38s
Details
2e4629d45e
lagertonne changed title from WIP: metrics: Make metrics actually usable to metrics: Make metrics actually usable 2024-12-23 09:02:55 +00:00
lagertonne force-pushed lagertonne/more-metrics-2 from 2e4629d45e to c3395093c7 2024-12-23 10:31:55 +00:00 Compare
lagertonne force-pushed lagertonne/more-metrics-2 from c3395093c7 to 7add159d23 2024-12-23 10:32:15 +00:00 Compare
lagertonne force-pushed lagertonne/more-metrics-2 from 7add159d23 to e43845b7dc 2024-12-23 10:38:34 +00:00 Compare
lagertonne force-pushed lagertonne/more-metrics-2 from e43845b7dc to cf14a029bb 2024-12-23 10:43:29 +00:00 Compare
lagertonne commented 2024-12-23 10:45:03 +00:00
Author
Owner
Copy link

If the test run through, this should be merge-able.

If the test run through, this should be merge-able.
j3d1 was assigned by lagertonne 2024-12-23 10:45:30 +00:00
lagertonne merged commit 2886d887f5 into testing 2024-12-23 13:20:45 +00:00
lagertonne deleted branch lagertonne/more-metrics-2 2024-12-23 13:20:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
help wanted

   
question

   
Subsystem/Backend

   
Subsystem/Frontend

   
Subsystem/Mail
  
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
help wanted
question
Subsystem/Backend
Subsystem/Frontend
Subsystem/Mail
Kind
Breaking
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
j3d1
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: c3lf/c3lf-system-3#104
No description provided.
Delete branch "lagertonne/more-metrics-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?