c3lf/c3lf-system-3
9
0
Fork 0
Code Issues 66 Pull requests 1 Projects 2 Releases Wiki Activity Actions

bton/prohibit_sending_empty_emails #100

Open
bton wants to merge 40 commits from bton/prohibit_sending_empty_emails into testing
pull from: bton/prohibit_sending_empty_emails
merge into: c3lf:testing
Conversation 2 Commits 40 Files changed 99 +12451 -1468
bton commented 2024-12-04 22:00:44 +00:00
Member
Copy link
No description provided.
bton added 3 commits 2024-12-04 22:00:45 +00:00
added a check in the make_reply function to ensure that mails have a body
All checks were successful
/ test (push) Successful in 55s
Details
/ test (pull_request) Successful in 52s
Details
c056e6880f
bton commented 2024-12-04 22:06:10 +00:00
Author
Member
Copy link

Why doesn't the test_mail_empty_body test fail?

Why doesn't the test_mail_empty_body test fail?
bton commented 2024-12-04 22:10:44 +00:00
Author
Member
Copy link

Ah because it is about receiving an empty mail not sending one

Ah because it is about receiving an empty mail not sending one
All checks were successful
/ test (push) Successful in 55s
Details
/ test (pull_request) Successful in 52s
Details
This pull request has changes conflicting with the target branch.
  • .forgejo/workflows/deploy_staging.yml
  • core/mail/protocol.py
  • core/mail/tests/v2/test_mails.py
  • core/tickets/api_v2.py
  • core/tickets/serializers.py
  • core/tickets/tests/v2/test_tickets.py
  • deploy/dev/docker-compose.yml
  • deploy/testing/docker-compose.yml
  • web/src/components/EditItem.vue
  • web/src/components/inputs/AsyncButton.vue
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bton/prohibit_sending_empty_emails:bton/prohibit_sending_empty_emails
git checkout bton/prohibit_sending_empty_emails

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout testing
git merge --no-ff bton/prohibit_sending_empty_emails
git checkout bton/prohibit_sending_empty_emails
git rebase testing
git checkout testing
git merge --ff-only bton/prohibit_sending_empty_emails
git checkout bton/prohibit_sending_empty_emails
git rebase testing
git checkout testing
git merge --no-ff bton/prohibit_sending_empty_emails
git checkout testing
git merge --squash bton/prohibit_sending_empty_emails
git checkout testing
git merge --ff-only bton/prohibit_sending_empty_emails
git checkout testing
git merge bton/prohibit_sending_empty_emails
git push origin testing
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
help wanted

   
question

   
Subsystem/Backend

   
Subsystem/Frontend

   
Subsystem/Mail
  
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
help wanted
question
Subsystem/Backend
Subsystem/Frontend
Subsystem/Mail
Kind
Breaking
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: c3lf/c3lf-system-3#100
No description provided.
Delete branch "bton/prohibit_sending_empty_emails"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?