more fixies

README.md

@@ -1,7 +1,5 @@
 # 🌈✨ SAUFEN - The Ultimate Drink Management Experience! 🍹🍻
 
-![Pride Colored Banner](https://via.placeholder.com/1200x300/ff8c00/ffffff?text=SAUFEN)
-
 ## 🎉 Welcome to Drink Paradise! 🎊
 
 **SAUFEN** is not just a drink management system - it's a **REVOLUTION** in how we celebrate and enjoy our favorite beverages! With its STUNNING interface and INCREDIBLE features, you'll wonder how you ever lived without it!

config/definitions.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use App\Service\ConfigurationService;
 use App\Enum\SystemSettingKey;
 use Doctrine\ORM\Configuration;
 use App\Settings;
@@ -44,7 +45,7 @@ return [
         Configuration $configuration
     ): EntityManagerInterface => new EntityManager($connection, $configuration),
 
-    Twig::class => function (\App\Service\ConfigurationService $config): Twig {
+    Twig::class => function (ConfigurationService $config): Twig {
         $paths = [__DIR__ . '/../templates'];
         $cache = __DIR__ . '/../var/cache/twig';
 

ecs.php

@@ -14,11 +14,15 @@ return ECSConfig::configure()
         __DIR__ . '/bin',
     ])
 
+    ->withRootFiles()
+
     // add a single rule
     ->withRules([
         NoUnusedImportsFixer::class,
     ])
 
+
+
     ->withPhpCsFixerSets(
         per: true,
         php84Migration: true,
@@ -30,4 +34,4 @@ return ECSConfig::configure()
     ->withPreparedSets(
         strict: true,
     )
-    ;
+;

rector.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
 
 return RectorConfig::configure()
     ->withPaths([
@@ -13,6 +12,7 @@ return RectorConfig::configure()
         __DIR__ . '/tests',
         __DIR__ . '/bin',
     ])
+    ->withRootFiles()
     ->withImportNames(removeUnusedImports: true)
     ->withPhpSets()
     ->withPreparedSets(
@@ -21,7 +21,4 @@ return RectorConfig::configure()
         earlyReturn: true,
         strictBooleans: true,
     )
-    ->withSkip([
-        ReadonlyPropertyRector::class,
-    ])
-;
+;

src/Controller/DashboardController.php

@@ -35,7 +35,7 @@ class DashboardController
             'lowStockItems' => $lowStockItems,
             'drinkTypes' => $drinkTypes,
             'showLowStockAlerts' => $showLowStockAlerts,
-            'showQuickUpdateForm' => $showQuickUpdateForm
+            'showQuickUpdateForm' => $showQuickUpdateForm,
         ]);
     }
 }

src/Controller/SettingsController.php

@@ -22,7 +22,7 @@ class SettingsController
     {
 
         $settings = [];
-        foreach($this->configurationService->getAllConfigs() as $setting) {
+        foreach ($this->configurationService->getAllConfigs() as $setting) {
             $settings[$setting->getKey()] = $setting->getValue();
         }
         return $this->view->render($response, 'settings/index.twig', [

src/Enum/SystemSettingKey.php

@@ -24,4 +24,4 @@ enum SystemSettingKey: string
     case SHOW_LOW_STOCK_ALERTS = 'show_low_stock_alerts';
     case SHOW_QUICK_UPDATE_FORM = 'show_quick_update_form';
     case ITEMS_PER_PAGE = 'items_per_page';
-}
+}

src/Service/DrinkTypeService.php

@@ -7,7 +7,6 @@ namespace App\Service;
 use InvalidArgumentException;
 use App\Entity\DrinkType;
 use App\Repository\DrinkTypeRepository;
-use App\Service\ConfigurationService;
 
 class DrinkTypeService
 {

src/Service/InventoryService.php

@@ -8,7 +8,6 @@ use App\Entity\DrinkType;
 use App\Entity\InventoryRecord;
 use App\Repository\DrinkTypeRepository;
 use App\Repository\InventoryRecordRepository;
-use App\Service\ConfigurationService;
 use App\Enum\SystemSettingKey;
 use DateTimeImmutable;
 

src/bootstrap.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use App\Settings;
 use App\Middleware\ErrorHandlerMiddleware;
 use Monolog\Logger;
 use Slim\App;
@@ -12,12 +13,12 @@ return (function (): App {
     // Create container
     $container = (require __DIR__ . '/../config/container.php')();
     /** @var \App\Settings $settings */
-    $settings = $container->get(\App\Settings::class);
+    $settings = $container->get(Settings::class);
 
     // create cache dirs
     foreach (['twig', 'doctrine/proxy'] as $dir) {
         if (!is_dir($settings->cacheDir . '/' . $dir)) {
-            mkdir($settings->cacheDir . '/' . $dir, 0777, true);
+            mkdir($settings->cacheDir . '/' . $dir, 0o777, true);
         }
     }