lubiana/futtern
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 20 Packages Wiki Activity Actions

improve test coverage #54

Merged
lubiana merged 2 commits from #42_vendor-menuitems-edit into main 2024-08-16 09:16:54 +00:00
Conversation 0 Commits 2 Files changed 3 +6 -12
3 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 2a28465626 - Show all commits

9
src/Entity/FoodOrder.php
View file

@ -67,15 +67,10 @@ class FoodOrder
public function isClosed(): bool public function isClosed(): bool
{ {
if ($this->closedAt === null) { if (! $this->closedAt instanceof DateTimeImmutable) {
return false; return false;
} }
return $this->closedAt < new DateTimeImmutable;
if ($this->closedAt < new DateTimeImmutable) {
return true;
}
return false;
} }
public function close(): static public function close(): static

2
tests/Controller/FoodOrderControllerTest.php
View file

@ -192,7 +192,6 @@ final class FoodOrderControllerTest extends DbWebTest
$this->manager->persist($order); $this->manager->persist($order);
$this->manager->flush(); $this->manager->flush();
$this->client->request('GET', sprintf('%s%s/open', $this->path, $order->getId())); $this->client->request('GET', sprintf('%s%s/open', $this->path, $order->getId()));
self::assertResponseRedirects("{$this->path}{$order->getId()}"); self::assertResponseRedirects("{$this->path}{$order->getId()}");
$openOrder = $this->repository->find($order->getId()); $openOrder = $this->repository->find($order->getId());
@ -209,7 +208,6 @@ final class FoodOrderControllerTest extends DbWebTest
$this->manager->persist($order); $this->manager->persist($order);
$this->manager->flush(); $this->manager->flush();
$this->client->request('GET', sprintf('%s%s/close', $this->path, $order->getId())); $this->client->request('GET', sprintf('%s%s/close', $this->path, $order->getId()));
self::assertResponseRedirects("{$this->path}{$order->getId()}"); self::assertResponseRedirects("{$this->path}{$order->getId()}");
$openOrder = $this->repository->find($order->getId()); $openOrder = $this->repository->find($order->getId());

7
tests/Controller/OrderItemControllerTest.php
View file

@ -8,6 +8,7 @@ use App\Entity\MenuItem;
use App\Entity\OrderItem; use App\Entity\OrderItem;
use App\Repository\MenuItemRepository; use App\Repository\MenuItemRepository;
use App\Tests\DbWebTest; use App\Tests\DbWebTest;
use DateTimeImmutable;
use Override; use Override;
use function sprintf; use function sprintf;
@ -66,7 +67,7 @@ final class OrderItemControllerTest extends DbWebTest
public function testNewOrderClosed(): void public function testNewOrderClosed(): void
{ {
$this->order->setClosedAt(new \DateTimeImmutable('-1 Hour')); $this->order->setClosedAt(new DateTimeImmutable('-1 Hour'));
$this->manager->persist($this->order); $this->manager->persist($this->order);
$this->manager->flush(); $this->manager->flush();
@ -172,7 +173,6 @@ final class OrderItemControllerTest extends DbWebTest
self::assertSame(1, $this->repository->count([])); self::assertSame(1, $this->repository->count([]));
self::assertSame(2, $this->menuItemRepository->count([])); self::assertSame(2, $this->menuItemRepository->count([]));
} }
public function testEditOrderClosed(): void public function testEditOrderClosed(): void
@ -182,13 +182,14 @@ final class OrderItemControllerTest extends DbWebTest
$orderItem->setExtras('My Extra'); $orderItem->setExtras('My Extra');
$orderItem->setFoodOrder($this->order); $orderItem->setFoodOrder($this->order);
$orderItem->setMenuItem($this->menuItem); $orderItem->setMenuItem($this->menuItem);
$this->order->close(); $this->order->close();
$this->manager->persist($orderItem); $this->manager->persist($orderItem);
$this->manager->persist($this->order); $this->manager->persist($this->order);
$this->manager->flush(); $this->manager->flush();
$crawler = $this->client->request('GET', sprintf('%s%s/edit', $this->path, $orderItem->getId())); $this->client->request('GET', sprintf('%s%s/edit', $this->path, $orderItem->getId()));
self::assertResponseRedirects(sprintf('/food/order/%s', $this->order->getId())); self::assertResponseRedirects(sprintf('/food/order/%s', $this->order->getId()));
} }