From 889ed63bc5ab6385d2aabcae1165621017178d4e Mon Sep 17 00:00:00 2001
From: lubiana <lubiana@hannover.ccc.de>
Date: Sat, 25 Jan 2025 02:27:11 +0100
Subject: [PATCH] sort and filter menuitems in aliasof select

---
 src/Form/MenuItemType.php | 45 ++++++++++++++++++++++++++++-----------
 1 file changed, 32 insertions(+), 13 deletions(-)

diff --git a/src/Form/MenuItemType.php b/src/Form/MenuItemType.php
index 96a6020..597d590 100644
--- a/src/Form/MenuItemType.php
+++ b/src/Form/MenuItemType.php
@@ -14,24 +14,43 @@ use Symfony\Component\OptionsResolver\OptionsResolver;
 
 final class MenuItemType extends AbstractType
 {
-    #[Override]
     public function buildForm(FormBuilderInterface $builder, array $options): void
     {
-        $vendor = $options['data']->getFoodVendor();
-        $vendorId = $vendor->getId();
-        $builder
-            ->add('name')
-            ->add('aliasOf', EntityType::class, [
+        $item = $options['data'];
+        assert($item instanceof MenuItem); // Ensure it's of the correct type
+        $vendorId = $item->getFoodVendor()?->getId(); // Use safe navigation operator in case FoodVendor is null
+
+        $builder->add('name'); // Basic field
+        $builder->add('aliases', EntityType::class, [
                 'class' => MenuItem::class,
                 'choice_label' => 'name',
-                'query_builder' => static fn(MenuItemRepository $repository): QueryBuilder => $repository
-                    ->createQueryBuilder('m')
-                    ->where('m.foodVendor = :vendorId')
-                    ->setParameter(':vendorId', $vendorId, UlidType::NAME),
-            ])
-        ;
-    }
+                'multiple' => true,
+                'expanded' => true,
+                'query_builder' => static function (MenuItemRepository $repository) use ($item, $vendorId): QueryBuilder {
+                    $qb = $repository->createQueryBuilder('m');
 
+                    // Build the main query with a NOT EXISTS constraint
+                    $qb
+                        ->where('m.foodVendor = :vendorId')
+                        ->andWhere('m.deletedAt IS NULL')
+                        ->andWhere('m.id != :id')
+                        ->andWhere(
+                            $qb->expr()->notIn('m.id',
+                                    $repository->createQueryBuilder('m2')
+                                        ->select('m2.id')
+                                        ->where('m2.aliasOf != m.id') // Reference m.id in the inner query
+                                        ->orWhere('m2.aliasOf IS NOT NULL')
+                                        ->getDQL() // The subquery's DQL string
+                                )
+                        )
+                        ->orderBy('m.name', 'ASC')
+                        ->setParameter('vendorId', $vendorId, UlidType::NAME) // ULID or appropriate type
+                        ->setParameter('id', $item->getId(), UlidType::NAME); // ULID or appropriate type
+
+                    return $qb;
+                },
+            ]);
+    }
     #[Override]
     public function configureOptions(OptionsResolver $resolver): void
     {