diff --git a/.forgejo/workflows/deploy_staging.yml b/.forgejo/workflows/deploy_staging.yml index 0dccd66..3b44d24 100644 --- a/.forgejo/workflows/deploy_staging.yml +++ b/.forgejo/workflows/deploy_staging.yml @@ -20,12 +20,9 @@ jobs: - name: Run django tests working-directory: core run: python3 manage.py test - - name: Run django coverage - working-directory: core - run: coverage manage.py test deploy: - needs: [ test ] + needs: [test] runs-on: docker steps: - uses: actions/checkout@v4 diff --git a/core/core/settings.py b/core/core/settings.py index cfa395c..94f15eb 100644 --- a/core/core/settings.py +++ b/core/core/settings.py @@ -56,7 +56,6 @@ TELEGRAM_GROUP_CHAT_ID = os.getenv('TELEGRAM_GROUP_CHAT_ID', '-1234567890') # Application definition INSTALLED_APPS = [ - *(['daphne'] if 'runserver' in sys.argv else []), 'django.contrib.admin', 'django.contrib.auth', 'django.contrib.contenttypes', @@ -130,7 +129,7 @@ TEMPLATES = [ }, ] -ASGI_APPLICATION = 'core.asgi.application' +WSGI_APPLICATION = 'core.wsgi.application' # Database # https://docs.djangoproject.com/en/4.2/ref/settings/#databases diff --git a/core/files/migrations/0003_ensure_creation_date.py b/core/files/migrations/0003_ensure_creation_date.py deleted file mode 100644 index 63e5760..0000000 --- a/core/files/migrations/0003_ensure_creation_date.py +++ /dev/null @@ -1,24 +0,0 @@ -# Generated by Django 4.2.7 on 2024-11-21 22:40 - -from django.db import migrations - - -class Migration(migrations.Migration): - dependencies = [ - ('files', '0002_alter_file_file'), - ] - - def set_creation_date(apps, schema_editor): - File = apps.get_model('files', 'File') - for file in File.objects.all(): - if file.created_at is None: - if not file.item.created_at is None: - file.created_at = file.item.created_at - else: - file.created_at = max(File.objects.filter( - id__lt=file.id, created_at__isnull=False).values_list('created_at', flat=True)) - file.save() - - operations = [ - migrations.RunPython(set_creation_date), - ] diff --git a/core/inventory/migrations/0007_remove_item_container_alter_item_event_itemplacement.py b/core/inventory/migrations/0007_remove_item_container_alter_item_event_itemplacement.py new file mode 100644 index 0000000..7ea5d8e --- /dev/null +++ b/core/inventory/migrations/0007_remove_item_container_alter_item_event_itemplacement.py @@ -0,0 +1,32 @@ +# Generated by Django 4.2.7 on 2024-11-20 01:48 + +from django.db import migrations, models +import django.db.models.deletion + + +class Migration(migrations.Migration): + + dependencies = [ + ('inventory', '0006_alter_event_table'), + ] + + operations = [ + migrations.RemoveField( + model_name='item', + name='container', + ), + migrations.AlterField( + model_name='item', + name='event', + field=models.ForeignKey(db_column='eid', on_delete=django.db.models.deletion.CASCADE, to='inventory.event'), + ), + migrations.CreateModel( + name='ItemPlacement', + fields=[ + ('id', models.AutoField(primary_key=True, serialize=False)), + ('timestamp', models.DateTimeField(auto_now_add=True)), + ('container', models.ForeignKey(db_column='cid', on_delete=django.db.models.deletion.CASCADE, related_name='item_history', to='inventory.container')), + ('item', models.ForeignKey(db_column='iid', on_delete=django.db.models.deletion.CASCADE, related_name='container_history', to='inventory.item')), + ], + ), + ] diff --git a/core/inventory/migrations/0007_remove_item_container_itemplacement_comment.py b/core/inventory/migrations/0007_remove_item_container_itemplacement_comment.py deleted file mode 100644 index 24c0f75..0000000 --- a/core/inventory/migrations/0007_remove_item_container_itemplacement_comment.py +++ /dev/null @@ -1,36 +0,0 @@ -# Generated by Django 4.2.7 on 2024-11-23 00:19 - -from django.db import migrations, models -import django.db.models.deletion - - -class Migration(migrations.Migration): - - dependencies = [ - ('inventory', '0006_alter_event_table'), - ] - - operations = [ - migrations.RemoveField( - model_name='item', - name='container', - ), - migrations.CreateModel( - name='ItemPlacement', - fields=[ - ('id', models.AutoField(primary_key=True, serialize=False)), - ('timestamp', models.DateTimeField(auto_now_add=True)), - ('container', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='item_history', to='inventory.container')), - ('item', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='container_history', to='inventory.item')), - ], - ), - migrations.CreateModel( - name='Comment', - fields=[ - ('id', models.AutoField(primary_key=True, serialize=False)), - ('comment', models.TextField()), - ('timestamp', models.DateTimeField(auto_now_add=True)), - ('item', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='comments', to='inventory.item')), - ], - ), - ] diff --git a/core/inventory/migrations/0008_alter_item_event_alter_itemplacement_container_and_more.py b/core/inventory/migrations/0008_alter_item_event_alter_itemplacement_container_and_more.py new file mode 100644 index 0000000..2fae077 --- /dev/null +++ b/core/inventory/migrations/0008_alter_item_event_alter_itemplacement_container_and_more.py @@ -0,0 +1,29 @@ +# Generated by Django 4.2.7 on 2024-11-20 01:52 + +from django.db import migrations, models +import django.db.models.deletion + + +class Migration(migrations.Migration): + + dependencies = [ + ('inventory', '0007_remove_item_container_alter_item_event_itemplacement'), + ] + + operations = [ + migrations.AlterField( + model_name='item', + name='event', + field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='inventory.event'), + ), + migrations.AlterField( + model_name='itemplacement', + name='container', + field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='item_history', to='inventory.container'), + ), + migrations.AlterField( + model_name='itemplacement', + name='item', + field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='container_history', to='inventory.item'), + ), + ] diff --git a/core/inventory/models.py b/core/inventory/models.py index fbbe0a9..50c1a5f 100644 --- a/core/inventory/models.py +++ b/core/inventory/models.py @@ -1,6 +1,7 @@ from itertools import groupby -from django.db import models +from django.core.files.base import ContentFile +from django.db import models, IntegrityError from django_softdelete.models import SoftDeleteModel, SoftDeleteManager @@ -47,6 +48,8 @@ class Item(SoftDeleteModel): groups = groupby(self.issue_relation_changes.all(), lambda rel: rel.issue_thread.id) return [sorted(v, key=lambda r: r.timestamp)[0].issue_thread for k, v in groups] + + objects = ItemManager() all_objects = models.Manager() @@ -70,7 +73,7 @@ class Container(SoftDeleteModel): def items(self): try: history = self.item_history.order_by('-timestamp').all() - return [v for k, v in groupby(history, key=lambda item: item.item.id)] + return [v for k, v in groupby(history, key=lambda item: item.item.id)] except AttributeError: return [] @@ -85,16 +88,6 @@ class ItemPlacement(models.Model): timestamp = models.DateTimeField(auto_now_add=True) -class Comment(models.Model): - id = models.AutoField(primary_key=True) - item = models.ForeignKey(Item, on_delete=models.CASCADE, related_name='comments') - comment = models.TextField() - timestamp = models.DateTimeField(auto_now_add=True) - - def __str__(self): - return str(self.issue_thread) + ' comment #' + str(self.id) - - class Event(models.Model): id = models.AutoField(primary_key=True) name = models.CharField(max_length=255) @@ -110,4 +103,4 @@ class Event(models.Model): return '[' + str(self.slug) + ']' + self.name class Meta: - db_table = 'common_event' + db_table = 'common_event' \ No newline at end of file diff --git a/core/inventory/serializers.py b/core/inventory/serializers.py index 79caddd..e4d3252 100644 --- a/core/inventory/serializers.py +++ b/core/inventory/serializers.py @@ -9,7 +9,24 @@ from mail.models import EventAddress from tickets.shared_serializers import BasicIssueSerializer +# class EventAdressSerializer(serializers.ModelSerializer): +# class Meta: +# model = EventAddress +# fields = ['address'] + +# def to_internal_value(self, data): +# if not isinstance(data, str): +# raise serializers.ValidationError('This field must be a string.') +# +# def create(self, validated_data): +# return EventAddress.objects.create(**validated_data) +# +# def validate(self, data): +# return isinstance(data, str) + + class EventSerializer(serializers.ModelSerializer): + # addresses = EventAdressSerializer(many=True, required=False) addresses = SlugRelatedField(many=True, slug_field='address', queryset=EventAddress.objects.all()) class Meta: @@ -17,13 +34,17 @@ class EventSerializer(serializers.ModelSerializer): fields = ['id', 'slug', 'name', 'start', 'end', 'pre_start', 'post_end', 'addresses'] read_only_fields = ['id'] - def to_internal_value(self, data): - data = data.copy() - addresses = data.pop('addresses', None) - dict = super().to_internal_value(data) - if addresses: - dict['addresses'] = [EventAddress.objects.get_or_create(address=x)[0] for x in addresses] - return dict + +# def update(self, instance, validated_data): +# addresses = validated_data.pop('addresses', None) +# instance.save(validated_data) +# if addresses: +# for address in addresses: +# nested_instance, created = EventAddress.objects.get_or_create(address=address) +# instance.addresses.add(nested_instance) +# +# return instance + class ContainerSerializer(serializers.ModelSerializer): itemCount = serializers.SerializerMethodField() @@ -38,14 +59,12 @@ class ContainerSerializer(serializers.ModelSerializer): class ItemSerializer(BasicItemSerializer): - timeline = serializers.SerializerMethodField() dataImage = serializers.CharField(write_only=True, required=False) related_issues = BasicIssueSerializer(many=True, read_only=True) class Meta: model = Item - fields = ['cid', 'box', 'id', 'description', 'file', 'dataImage', 'returned', 'event', 'related_issues', - 'timeline'] + fields = ['cid', 'box', 'id', 'description', 'file', 'dataImage', 'returned', 'event', 'related_issues'] read_only_fields = ['id'] def to_internal_value(self, data): @@ -87,26 +106,6 @@ class ItemSerializer(BasicItemSerializer): instance.files.add(file) return super().update(instance, validated_data) - @staticmethod - def get_timeline(obj): - timeline = [] - for comment in obj.comments.all(): - timeline.append({ - 'type': 'comment', - 'id': comment.id, - 'timestamp': comment.timestamp, - 'comment': comment.comment, - }) - for relation in (obj.issue_relation_changes.all()): - timeline.append({ - 'type': 'issue_relation', - 'id': relation.id, - 'status': relation.status, - 'timestamp': relation.timestamp, - 'issue_thread': BasicIssueSerializer(relation.issue_thread).data, - }) - return sorted(timeline, key=lambda x: x['timestamp']) - class SearchResultSerializer(serializers.Serializer): search_score = serializers.IntegerField() diff --git a/core/inventory/shared_serializers.py b/core/inventory/shared_serializers.py index 2cafd5f..0bd44c3 100644 --- a/core/inventory/shared_serializers.py +++ b/core/inventory/shared_serializers.py @@ -24,7 +24,7 @@ class BasicItemSerializer(serializers.ModelSerializer): def get_file(self, instance): if len(instance.files.all()) > 0: - return sorted(instance.files.all(), key=lambda x: x.created_at, reverse=True)[0].hash + return instance.files.all().order_by('-created_at')[0].hash return None def get_returned(self, instance): diff --git a/core/inventory/tests/v2/test_events.py b/core/inventory/tests/v2/test_events.py index bd58515..11c17dc 100644 --- a/core/inventory/tests/v2/test_events.py +++ b/core/inventory/tests/v2/test_events.py @@ -50,16 +50,14 @@ class EventTestCase(TestCase): def test_update_event(self): from rest_framework.test import APIClient event = Event.objects.create(slug='EVENT1', name='Event 1') - response = APIClient().patch(f'/api/2/events/{event.id}/', {'addresses': ['foo@bar.baz', 'foo1@bar.baz']}) + response = APIClient().patch(f'/api/2/events/{event.id}/', {'addresses': []})#'foo@bar.baz', 'foo1@bar.baz' self.assertEqual(response.status_code, 200) self.assertEqual(response.json()['slug'], 'EVENT1') self.assertEqual(response.json()['name'], 'Event 1') - self.assertEqual(2, len(response.json()['addresses'])) - self.assertEqual('foo@bar.baz', response.json()['addresses'][0]) - self.assertEqual('foo1@bar.baz', response.json()['addresses'][1]) self.assertEqual(len(Event.objects.all()), 1) self.assertEqual(Event.objects.all()[0].slug, 'EVENT1') self.assertEqual(Event.objects.all()[0].name, 'Event 1') + #self.assertEqual(1, len(response.json()[0]['addresses'])) def test_remove_event(self): event = Event.objects.create(slug='EVENT1', name='Event 1') @@ -69,26 +67,13 @@ class EventTestCase(TestCase): self.assertEqual(response.status_code, 204) self.assertEqual(len(Event.objects.all()), 1) - def test_event_with_address(self): + def test_items2(self): from mail.models import EventAddress event1 = Event.objects.create(slug='TEST1', name='Event') - EventAddress.objects.create(event=event1, address='foo@bar.baz') + EventAddress.objects.create(event=Event.objects.get(slug='TEST1'), address='foo@bar.baz') response = self.client.get('/api/2/events/') self.assertEqual(response.status_code, 200) self.assertEqual(1, len(response.json())) self.assertEqual('TEST1', response.json()[0]['slug']) self.assertEqual('Event', response.json()[0]['name']) self.assertEqual(1, len(response.json()[0]['addresses'])) - - def test_items_remove_addresss(self): - from mail.models import EventAddress - from rest_framework.test import APIClient - event1 = Event.objects.create(slug='TEST1', name='Event') - EventAddress.objects.create(event=event1, address='foo@bar.baz') - EventAddress.objects.create(event=event1, address='fo1o@bar.baz') - response = APIClient().patch(f'/api/2/events/{event1.id}/', {'addresses': ['foo1@bar.baz']}) - self.assertEqual(response.status_code, 200) - self.assertEqual('TEST1', response.json()['slug']) - self.assertEqual('Event', response.json()['name']) - self.assertEqual(1, len(response.json()['addresses'])) - self.assertEqual('foo1@bar.baz', response.json()['addresses'][0]) diff --git a/core/inventory/tests/v2/test_items.py b/core/inventory/tests/v2/test_items.py index 8a38b86..144797a 100644 --- a/core/inventory/tests/v2/test_items.py +++ b/core/inventory/tests/v2/test_items.py @@ -1,5 +1,3 @@ -from datetime import datetime, timedelta - from django.utils import timezone from django.test import TestCase, Client from django.contrib.auth.models import Permission @@ -7,12 +5,10 @@ from knox.models import AuthToken from authentication.models import ExtendedUser from files.models import File -from inventory.models import Event, Container, Item, Comment +from inventory.models import Event, Container, Item from base64 import b64encode -from tickets.models import IssueThread, ItemRelation - class ItemTestCase(TestCase): @@ -24,29 +20,14 @@ class ItemTestCase(TestCase): self.user.user_permissions.add(*Permission.objects.all()) self.token = AuthToken.objects.create(user=self.user) self.client = Client(headers={'Authorization': 'Token ' + self.token[1]}) - self.issue = IssueThread.objects.create( - name="test issue", - event=self.event, - ) def test_empty(self): response = self.client.get(f'/api/2/{self.event.slug}/item/') self.assertEqual(response.status_code, 200) self.assertEqual(response.content, b'[]') - def test_members_and_timeline(self): - now = datetime.now() + def test_members(self): item = Item.objects.create(container=self.box, event=self.event, description='1') - comment = Comment.objects.create( - item=item, - comment="test", - timestamp=now + timedelta(seconds=3), - ) - match = ItemRelation.objects.create( - issue_thread=self.issue, - item = item, - timestamp=now + timedelta(seconds=5), - ) response = self.client.get(f'/api/2/{self.event.slug}/item/') self.assertEqual(response.status_code, 200) self.assertEqual(len(response.json()), 1) @@ -57,24 +38,7 @@ class ItemTestCase(TestCase): self.assertEqual(response.json()[0]['file'], None) self.assertEqual(response.json()[0]['returned'], False) self.assertEqual(response.json()[0]['event'], self.event.slug) - self.assertEqual(len(response.json()[0]['timeline']), 2) - self.assertEqual(response.json()[0]['timeline'][0]['type'], 'comment') - self.assertEqual(response.json()[0]['timeline'][1]['type'], 'issue_relation') - self.assertEqual(response.json()[0]['timeline'][0]['id'], comment.id) - self.assertEqual(response.json()[0]['timeline'][1]['id'], match.id) - self.assertEqual(response.json()[0]['timeline'][0]['comment'], 'test') - self.assertEqual(response.json()[0]['timeline'][0]['timestamp'], - comment.timestamp.strftime('%Y-%m-%dT%H:%M:%S.%fZ')) - self.assertEqual(response.json()[0]['timeline'][1]['status'], 'possible') - self.assertEqual(response.json()[0]['timeline'][1]['timestamp'], - match.timestamp.strftime('%Y-%m-%dT%H:%M:%S.%fZ')) - self.assertEqual(response.json()[0]['timeline'][1]['issue_thread']['name'], "test issue") - self.assertEqual(response.json()[0]['timeline'][1]['issue_thread']['event'], "EVENT") - self.assertEqual(response.json()[0]['timeline'][1]['issue_thread']['state'], "pending_new") - self.assertEqual(len(response.json()[0]['related_issues']), 1) - self.assertEqual(response.json()[0]['related_issues'][0]['name'], "test issue") - self.assertEqual(response.json()[0]['related_issues'][0]['event'], "EVENT") - self.assertEqual(response.json()[0]['related_issues'][0]['state'], "pending_new") + self.assertEqual(len(response.json()[0]['related_issues']), 0) def test_members_with_file(self): import base64 @@ -92,23 +56,6 @@ class ItemTestCase(TestCase): self.assertEqual(response.json()[0]['event'], self.event.slug) self.assertEqual(len(response.json()[0]['related_issues']), 0) - def test_members_with_two_file(self): - import base64 - item = Item.objects.create(container=self.box, event=self.event, description='1') - file1 = File.objects.create(item=item, data="data:text/plain;base64," + base64.b64encode(b"foo").decode('utf-8')) - file2 = File.objects.create(item=item, data="data:text/plain;base64," + base64.b64encode(b"bar").decode('utf-8')) - response = self.client.get(f'/api/2/{self.event.slug}/item/') - self.assertEqual(response.status_code, 200) - self.assertEqual(len(response.json()), 1) - self.assertEqual(response.json()[0]['id'], item.id) - self.assertEqual(response.json()[0]['description'], '1') - self.assertEqual(response.json()[0]['box'], 'BOX') - self.assertEqual(response.json()[0]['cid'], self.box.id) - self.assertEqual(response.json()[0]['file'], file2.hash) - self.assertEqual(response.json()[0]['returned'], False) - self.assertEqual(response.json()[0]['event'], self.event.slug) - self.assertEqual(len(response.json()[0]['related_issues']), 0) - def test_multi_members(self): Item.objects.create(container=self.box, event=self.event, description='1') Item.objects.create(container=self.box, event=self.event, description='2') diff --git a/core/mail/migrations/0007_alter_eventaddress_address.py b/core/mail/migrations/0007_alter_eventaddress_address.py index 5d71449..7b979a5 100644 --- a/core/mail/migrations/0007_alter_eventaddress_address.py +++ b/core/mail/migrations/0007_alter_eventaddress_address.py @@ -1,4 +1,4 @@ -# Generated by Django 4.2.7 on 2024-11-22 18:57 +# Generated by Django 4.2.7 on 2024-11-18 01:50 from django.db import migrations, models diff --git a/core/mail/protocol.py b/core/mail/protocol.py index 02d87ab..6b4dc6d 100644 --- a/core/mail/protocol.py +++ b/core/mail/protocol.py @@ -71,7 +71,7 @@ def make_reply(reply_email, references=None, event=None): reply["From"] = reply_email.sender reply["To"] = reply_email.recipient reply["Subject"] = reply_email.subject - reply["Reply-To"] = f"{event.lower()}@{MAIL_DOMAIN}" + reply["Reply-To"] = f"{event}@{MAIL_DOMAIN}" if reply_email.in_reply_to: reply["In-Reply-To"] = reply_email.in_reply_to if reply_email.reference: diff --git a/core/tickets/api_v2.py b/core/tickets/api_v2.py index 9e601ba..008e0af 100644 --- a/core/tickets/api_v2.py +++ b/core/tickets/api_v2.py @@ -21,8 +21,7 @@ from tickets.shared_serializers import RelationSerializer class IssueViewSet(viewsets.ModelViewSet): serializer_class = IssueSerializer - queryset = IssueThread.objects.all().prefetch_related('state_changes', 'comments', 'emails', 'emails__attachments', - 'assignments', 'item_relation_changes', 'shipping_vouchers') + queryset = IssueThread.objects.all() class RelationViewSet(viewsets.ModelViewSet): diff --git a/core/tickets/migrations/0012_alter_itemrelation_item.py b/core/tickets/migrations/0012_alter_itemrelation_item.py new file mode 100644 index 0000000..a8ea2a5 --- /dev/null +++ b/core/tickets/migrations/0012_alter_itemrelation_item.py @@ -0,0 +1,20 @@ +# Generated by Django 4.2.7 on 2024-11-20 01:48 + +from django.db import migrations, models +import django.db.models.deletion + + +class Migration(migrations.Migration): + + dependencies = [ + ('inventory', '0007_remove_item_container_alter_item_event_itemplacement'), + ('tickets', '0011_train_old_spam'), + ] + + operations = [ + migrations.AlterField( + model_name='itemrelation', + name='item', + field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='issue_relations', to='inventory.item'), + ), + ] diff --git a/core/tickets/migrations/0012_remove_issuethread_related_items_and_more.py b/core/tickets/migrations/0013_remove_issuethread_related_items_and_more.py similarity index 80% rename from core/tickets/migrations/0012_remove_issuethread_related_items_and_more.py rename to core/tickets/migrations/0013_remove_issuethread_related_items_and_more.py index d8a24c7..29da48f 100644 --- a/core/tickets/migrations/0012_remove_issuethread_related_items_and_more.py +++ b/core/tickets/migrations/0013_remove_issuethread_related_items_and_more.py @@ -1,4 +1,4 @@ -# Generated by Django 4.2.7 on 2024-11-20 23:58 +# Generated by Django 4.2.7 on 2024-11-20 23:34 from django.db import migrations, models import django.db.models.deletion @@ -7,8 +7,8 @@ import django.db.models.deletion class Migration(migrations.Migration): dependencies = [ - ('inventory', '0006_alter_event_table'), - ('tickets', '0011_train_old_spam'), + ('inventory', '0008_alter_item_event_alter_itemplacement_container_and_more'), + ('tickets', '0012_alter_itemrelation_item'), ] operations = [ diff --git a/core/tickets/models.py b/core/tickets/models.py index f7ddb7b..2c14687 100644 --- a/core/tickets/models.py +++ b/core/tickets/models.py @@ -52,11 +52,7 @@ class IssueThread(SoftDeleteModel): @property def state(self): try: - state_changes = sorted(self.state_changes.all(), key=lambda x: x.timestamp, reverse=True) - if state_changes: - return state_changes[0].state - else: - return None + return self.state_changes.order_by('-timestamp').first().state except AttributeError: return 'none' @@ -71,11 +67,7 @@ class IssueThread(SoftDeleteModel): @property def assigned_to(self): try: - assignments = sorted(self.assignments.all(), key=lambda x: x.timestamp, reverse=True) - if assignments: - return assignments[0].assigned_to - else: - return None + return self.assignments.order_by('-timestamp').first().assigned_to except AttributeError: return None diff --git a/core/tickets/serializers.py b/core/tickets/serializers.py index 4faa69c..4539283 100644 --- a/core/tickets/serializers.py +++ b/core/tickets/serializers.py @@ -63,12 +63,14 @@ class IssueSerializer(BasicIssueSerializer): @staticmethod def get_last_activity(self): try: - last_state_change = max([t.timestamp for t in self.state_changes.all()]) if self.state_changes.exists() else None - last_comment = max([t.timestamp for t in self.comments.all()]) if self.comments.exists() else None - last_mail = max([t.timestamp for t in self.emails.all()]) if self.emails.exists() else None - last_assignment = max([t.timestamp for t in self.assignments.all()]) if self.assignments.exists() else None - - last_relation = max([t.timestamp for t in self.item_relation_changes.all()]) if self.item_relation_changes.exists() else None + last_state_change = self.state_changes.order_by('-timestamp').first().timestamp \ + if self.state_changes.count() > 0 else None + last_comment = self.comments.order_by('-timestamp').first().timestamp if self.comments.count() > 0 else None + last_mail = self.emails.order_by('-timestamp').first().timestamp if self.emails.count() > 0 else None + last_assignment = self.assignments.order_by('-timestamp').first().timestamp if \ + self.assignments.count() > 0 else None + last_relation = self.item_relation_changes.order_by('-timestamp').first().timestamp if \ + self.item_relation_changes.count() > 0 else None args = [x for x in [last_state_change, last_comment, last_mail, last_assignment, last_relation] if x is not None] return max(args) diff --git a/core/tickets/tests/v2/test_tickets.py b/core/tickets/tests/v2/test_tickets.py index 8f72392..54bd3fe 100644 --- a/core/tickets/tests/v2/test_tickets.py +++ b/core/tickets/tests/v2/test_tickets.py @@ -5,7 +5,7 @@ from django.test import TestCase, Client from authentication.models import ExtendedUser from inventory.models import Event, Container, Item from mail.models import Email, EmailAttachment -from tickets.models import IssueThread, StateChange, Comment, ItemRelation, Assignment +from tickets.models import IssueThread, StateChange, Comment, ItemRelation from django.contrib.auth.models import Permission from knox.models import AuthToken @@ -53,24 +53,19 @@ class IssueApiTest(TestCase): in_reply_to=mail1.reference, timestamp=now + timedelta(seconds=2), ) - assignment = Assignment.objects.create( - issue_thread=issue, - assigned_to=self.user, - timestamp=now + timedelta(seconds=3), - ) comment = Comment.objects.create( issue_thread=issue, comment="test", - timestamp=now + timedelta(seconds=4), + timestamp=now + timedelta(seconds=3), ) match = ItemRelation.objects.create( issue_thread=issue, - item=self.item, + item = self.item, timestamp=now + timedelta(seconds=5), ) self.assertEqual('pending_new', issue.state) self.assertEqual('test issue', issue.name) - self.assertEqual(self.user, issue.assigned_to) + self.assertEqual(None, issue.assigned_to) self.assertEqual(36, len(issue.uuid)) response = self.client.get('/api/2/tickets/') self.assertEqual(response.status_code, 200) @@ -79,16 +74,14 @@ class IssueApiTest(TestCase): self.assertEqual(response.json()[0]['name'], "test issue") self.assertEqual(response.json()[0]['state'], "pending_new") self.assertEqual(response.json()[0]['event'], "evt") - self.assertEqual(response.json()[0]['assigned_to'], self.user.username) + self.assertEqual(response.json()[0]['assigned_to'], None) self.assertEqual(response.json()[0]['uuid'], issue.uuid) self.assertEqual(response.json()[0]['last_activity'], match.timestamp.strftime('%Y-%m-%dT%H:%M:%S.%fZ')) - self.assertEqual(len(response.json()[0]['timeline']), 6) + self.assertEqual(len(response.json()[0]['timeline']), 5) self.assertEqual(response.json()[0]['timeline'][0]['type'], 'state') self.assertEqual(response.json()[0]['timeline'][1]['type'], 'mail') self.assertEqual(response.json()[0]['timeline'][2]['type'], 'mail') - self.assertEqual(response.json()[0]['timeline'][3]['type'], 'assignment') - self.assertEqual(response.json()[0]['timeline'][4]['type'], 'comment') - self.assertEqual(response.json()[0]['timeline'][5]['type'], 'item_relation') + self.assertEqual(response.json()[0]['timeline'][3]['type'], 'comment') self.assertEqual(response.json()[0]['timeline'][1]['id'], mail1.id) self.assertEqual(response.json()[0]['timeline'][2]['id'], mail2.id) self.assertEqual(response.json()[0]['timeline'][3]['id'], comment.id) @@ -105,19 +98,15 @@ class IssueApiTest(TestCase): self.assertEqual(response.json()[0]['timeline'][2]['body'], 'test') self.assertEqual(response.json()[0]['timeline'][2]['timestamp'], mail2.timestamp.strftime('%Y-%m-%dT%H:%M:%S.%fZ')) - self.assertEqual(response.json()[0]['timeline'][3]['assigned_to'], self.user.username) + self.assertEqual(response.json()[0]['timeline'][3]['comment'], 'test') self.assertEqual(response.json()[0]['timeline'][3]['timestamp'], - assignment.timestamp.strftime('%Y-%m-%dT%H:%M:%S.%fZ')) - self.assertEqual(response.json()[0]['timeline'][4]['comment'], 'test') - self.assertEqual(response.json()[0]['timeline'][4]['timestamp'], comment.timestamp.strftime('%Y-%m-%dT%H:%M:%S.%fZ')) - self.assertEqual(response.json()[0]['timeline'][5]['status'], 'possible') - self.assertEqual(response.json()[0]['timeline'][5]['timestamp'], + self.assertEqual(response.json()[0]['timeline'][4]['status'], 'possible') + self.assertEqual(response.json()[0]['timeline'][4]['timestamp'], match.timestamp.strftime('%Y-%m-%dT%H:%M:%S.%fZ')) - self.assertEqual(response.json()[0]['timeline'][5]['item']['description'], "foo") - self.assertEqual(response.json()[0]['timeline'][5]['item']['event'], "evt") - self.assertEqual(response.json()[0]['timeline'][5]['item']['box'], "box1") - self.assertEqual(len(response.json()[0]['related_items']), 1) + self.assertEqual(response.json()[0]['timeline'][4]['item']['description'], "foo") + self.assertEqual(response.json()[0]['timeline'][4]['item']['event'], "evt") + self.assertEqual(response.json()[0]['timeline'][4]['item']['box'], "box1") self.assertEqual(response.json()[0]['related_items'][0]['description'], "foo") self.assertEqual(response.json()[0]['related_items'][0]['event'], "evt") self.assertEqual(response.json()[0]['related_items'][0]['box'], "box1") @@ -314,6 +303,16 @@ class IssueApiTest(TestCase): content_type='application/json') self.assertEqual(response.status_code, 400) + # def test_post_comment(self): + # issue = IssueThread.objects.create( + # name="test issue", + # ) + # response = self.client.post('/api/2/comments/', {'comment': 'test', 'issue_thread': issue.id}) + # self.assertEqual(response.status_code, 201) + # self.assertEqual(response.json()['comment'], 'test') + # self.assertEqual(response.json()['issue_thread'], issue.id) + # self.assertEqual(response.json()['timestamp'], response.json()['timestamp']) + def test_post_comment_altenative(self): issue = IssueThread.objects.create( name="test issue", diff --git a/web/src/components/EditItem.vue b/web/src/components/EditItem.vue index 833bfd5..9bea6f9 100644 --- a/web/src/components/EditItem.vue +++ b/web/src/components/EditItem.vue @@ -12,16 +12,13 @@ field="description" :validation-fn="str => str && str.length > 0" /> -
{{ item }}
-