core/.coveragerc

@@ -1,14 +0,0 @@
-[run]
-source = .
-
-[report]
-fail_under = 100
-show_missing = True
-skip_covered = True
-omit =
-    */tests/*
-    */migrations/*
-    core/asgi.py
-    core/wsgi.py
-    core/settings.py
-    manage.py

core/inventory/serializers.py

@@ -3,21 +3,12 @@ from rest_framework import serializers
 
 from files.models import File
 from inventory.models import Event, Container, Item
-from mail.models import EventAddress
-
-
-class EventAdressSerializer(serializers.ModelSerializer):
-    class Meta:
-        model = EventAddress
-        fields = ['address']
 
 
 class EventSerializer(serializers.ModelSerializer):
-    addresses = EventAdressSerializer(many=True, required=False)
-
     class Meta:
         model = Event
-        fields = ['eid', 'slug', 'name', 'start', 'end', 'pre_start', 'post_end', 'addresses']
+        fields = ['eid', 'slug', 'name', 'start', 'end', 'pre_start', 'post_end']
         read_only_fields = ['eid']
 
 

core/inventory/tests/v2/test_events.py

@@ -54,15 +54,3 @@ class EventTestCase(TestCase):
         response = client.delete(f'/api/2/events/{event.eid}/')
         self.assertEqual(response.status_code, 204)
         self.assertEqual(len(Event.objects.all()), 1)
-
-    def test_items2(self):
-        from mail.models import EventAddress
-        event1 = Event.objects.create(slug='TEST1', name='Event')
-        EventAddress.objects.create(event=Event.objects.get(slug='TEST1'), address='foo@bar.baz')
-        response = self.client.get('/api/2/events/')
-        self.assertEqual(response.status_code, 200)
-        self.assertEqual(1, len(response.json()))
-        self.assertEqual('TEST1', response.json()[0]['slug'])
-        self.assertEqual('Event', response.json()[0]['name'])
-        self.assertEqual(1, len(response.json()[0]['addresses']))
-

core/mail/migrations/0005_alter_eventaddress_event.py

@@ -1,20 +0,0 @@
-# Generated by Django 4.2.7 on 2024-11-03 18:30
-
-from django.db import migrations, models
-import django.db.models.deletion
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('inventory', '0004_alter_event_created_at_alter_item_created_at'),
-        ('mail', '0004_alter_emailattachment_file'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='eventaddress',
-            name='event',
-            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.SET_NULL, related_name='addresses', to='inventory.event'),
-        ),
-    ]

core/mail/models.py

@@ -31,7 +31,7 @@ class Email(SoftDeleteModel):
 
 class EventAddress(models.Model):
     id = models.AutoField(primary_key=True)
-    event = models.ForeignKey(Event, models.SET_NULL, null=True, related_name='addresses')
+    event = models.ForeignKey(Event, models.SET_NULL, null=True)
     address = models.CharField(max_length=255)
 
 

core/mail/protocol.py

@@ -1,5 +1,4 @@
 import logging
-from re import match
 
 import aiosmtplib
 from channels.layers import get_channel_layer
@@ -11,10 +10,6 @@ from notify_sessions.models import SystemEvent
 from tickets.models import IssueThread
 
 
-class SpecialMailException(Exception):
-    pass
-
-
 def find_quoted_printable(s, marker):
     positions = [i for i in range(len(s)) if s.lower().startswith('=?utf-8?' + marker + '?', i)]
     for pos in positions:
@@ -185,13 +180,13 @@ def receive_email(envelope, log=None):
     header_in_reply_to = parsed.get('In-Reply-To')
     header_message_id = parsed.get('Message-ID')
 
-    if match(r'^([a-zA-Z ]*<)?MAILER-DAEMON@', header_from) and envelope.mail_from.strip("<>") == "":
+    if header_from != envelope.mail_from:
-        log.warning("Ignoring mailer daemon")
+        log.warning("Header from does not match envelope from")
-        raise SpecialMailException("Ignoring mailer daemon")
+        log.info(f"Header from: {header_from}, envelope from: {envelope.mail_from}")
 
-    if Email.objects.filter(reference=header_message_id).exists():  # break before issue thread is created
+    if header_to != envelope.rcpt_tos[0]:
-        log.warning("Email already exists")
+        log.warning("Header to does not match envelope to")
-        raise Exception("Email already exists")
+        log.info(f"Header to: {header_to}, envelope to: {envelope.rcpt_tos[0]}")
 
     recipient = envelope.rcpt_tos[0].lower() if envelope.rcpt_tos else header_to.lower()
     sender = envelope.mail_from if envelope.mail_from else header_from
@@ -238,7 +233,7 @@ Your c3lf (Cloakroom + Lost&Found) Team'''.format(active_issue_thread.short_uuid
             active_issue_thread.state = 'pending_open'
             active_issue_thread.save()
 
-    return email, new, reply, active_issue_thread
+    return email, new, reply
 
 
 class LMTPHandler:
@@ -260,7 +255,7 @@ class LMTPHandler:
         content = None
         try:
             content = envelope.content
-            email, new, reply, thread = await receive_email(envelope, log)
+            email, new, reply = await receive_email(envelope, log)
             log.info(f"Created email {email.id}")
             systemevent = await database_sync_to_async(SystemEvent.objects.create)(type='email received',
                                                                                    reference=email.id)
@@ -268,20 +263,14 @@ class LMTPHandler:
             channel_layer = get_channel_layer()
             await channel_layer.group_send(
                 'general', {"type": "generic.event", "name": "send_message_to_frontend", "event_id": systemevent.id,
-                            "message": "email received"})
+                            "message": "email received"}
+            )
             log.info(f"Sent message to frontend")
             if new and reply:
                 log.info('Sending message to %s' % reply['To'])
                 await send_smtp(reply)
                 log.info("Sent auto reply")
 
-            return '250 Message accepted for delivery'
-        except SpecialMailException as e:
-            import uuid
-            random_filename = 'special-' + str(uuid.uuid4())
-            with open(random_filename, 'wb') as f:
-                f.write(content)
-            log.warning(f"Special mail exception: {e} saved to {random_filename}")
             return '250 Message accepted for delivery'
         except Exception as e:
             from hashlib import sha256

core/mail/tests/v2/test_mails.py

@@ -760,6 +760,7 @@ dGVzdGltYWdl
         response = self.client.post(f'/api/2/tickets/{issue_thread.id}/reply/', {
             'message': 'test'
         })
+        aiosmtplib.send.assert_called_once()
         self.assertEqual(response.status_code, 201)
         self.assertEqual(5, len(Email.objects.all()))
         self.assertEqual(5, len(Email.objects.filter(issue_thread=issue_thread)))
@@ -775,7 +776,6 @@ dGVzdGltYWdl
         self.assertEqual('test subject', IssueThread.objects.all()[0].name)
         self.assertEqual('pending_new', IssueThread.objects.all()[0].state)
         self.assertEqual(None, IssueThread.objects.all()[0].assigned_to)
-        aiosmtplib.send.assert_called_once()
 
     def test_mail_4byte_unicode_emoji(self):
         from aiosmtpd.smtp import Envelope

core/requirements.dev.txt

@@ -1,6 +1,3 @@
-aiodns==3.2.0
-aiohttp==3.9.5
-aiosignal==1.3.1
 aiosmtpd==1.4.4.post2
 aiosmtplib==3.0.1
 anyio==4.1.0
@@ -31,7 +28,6 @@ django-rest-knox==4.2.0
 django-soft-delete==0.9.21
 djangorestframework==3.14.0
 drf-yasg==1.21.7
-frozenlist==1.4.1
 h11==0.14.0
 hyperlink==21.0.0
 idna==3.4
@@ -42,13 +38,11 @@ Jinja2==3.1.2
 MarkupSafe==2.1.3
 msgpack==1.0.7
 msgpack-python==0.5.6
-multidict==6.0.5
 openapi-codec==1.3.2
 packaging==23.2
 Pillow==10.1.0
 pyasn1==0.5.1
 pyasn1-modules==0.3.0
-pycares==4.4.0
 pycparser==2.21
 pyOpenSSL==23.3.0
 python-dotenv==1.0.0
@@ -71,5 +65,4 @@ urllib3==2.1.0
 uvicorn==0.24.0.post1
 watchfiles==0.21.0
 websockets==12.0
-yarl==1.9.4
 zope.interface==6.1

core/requirements.prod.txt

@@ -1,6 +1,3 @@
-aiodns==3.2.0
-aiohttp==3.9.5
-aiosignal==1.3.1
 aiosmtpd==1.4.4.post2
 aiosmtplib==3.0.1
 asgiref==3.7.2

core/tickets/api_v2.py

@@ -10,7 +10,6 @@ from asgiref.sync import async_to_sync
 from channels.layers import get_channel_layer
 
 from core.settings import MAIL_DOMAIN
-from inventory.models import Event
 from mail.models import Email
 from mail.protocol import send_smtp, make_reply, collect_references
 from notify_sessions.models import SystemEvent

deploy/dev/Dockerfile.backend

@@ -1,13 +0,0 @@
-FROM python:3.11-bookworm
-LABEL authors="lagertonne"
-
-ENV PYTHONUNBUFFERED 1
-RUN mkdir /code
-WORKDIR /code
-COPY requirements.dev.txt /code/
-COPY requirements.prod.txt /code/
-RUN apt update && apt install -y mariadb-client
-RUN pip install -r requirements.dev.txt
-RUN pip install -r requirements.prod.txt
-RUN pip install mysqlclient
-COPY .. /code/

deploy/dev/Dockerfile.frontend

@@ -1,6 +0,0 @@
-FROM docker.io/node:22
-
-RUN mkdir /web
-WORKDIR /web
-COPY package.json /web/
-RUN npm install

deploy/dev/docker-compose.yml

@@ -1,33 +0,0 @@
-services:
-  core:
-    build:
-      context: ../../core
-      dockerfile: ../deploy/dev/Dockerfile.backend
-    command: bash -c 'python manage.py migrate && python manage.py runserver 0.0.0.0:8000'
-    environment:
-      - HTTP_HOST=core
-      #- DATABASE_URL
-    volumes:
-      - ../../core:/code
-    ports:
-      - "8000:8000"
-
-  frontend:
-    build:
-      context: ../../web
-      dockerfile: ../deploy/dev/Dockerfile.frontend
-    command: npm run serve
-    volumes:
-      - ../../web:/web:ro
-      - /web/node_modules
-      - ./vue.config.js:/web/vue.config.js
-    ports:
-      - "8080:8080"
-
-  db:
-    image: mariadb
-    environment:
-      MARIADB_RANDOM_ROOT_PASSWORD: true
-      MARIADB_DATABASE: system3
-      MARIADB_USER: system3
-      MARIADB_PASSWORD: system3

deploy/dev/vue.config.js

@@ -1,27 +0,0 @@
-// vue.config.js
-
-module.exports = {
-    devServer: {
-        headers: {
-            "Access-Control-Allow-Origin": "*",
-            "Access-Control-Allow-Headers": "*",
-            "Access-Control-Allow-Methods": "*"
-        },
-        proxy: {
-            '^/media/2': {
-                target: 'http://core:8000/',
-            },
-            '^/api/2': {
-                target: 'http://core:8000/',
-            },
-            '^/api/1': {
-                target: 'http://core:8000/',
-            },
-            '^/ws/2': {
-                target: 'http://core:8000/',
-                ws: true,
-                logLevel: 'debug',
-            },
-        }
-    }
-}

web/src/components/AsyncLoader.vue

@@ -1,133 +0,0 @@
-<template>
-    <div class="async-wrapper" :class="{ 'loaded': loaded }">
-        <div class="deferred">
-            <slot></slot>
-        </div>
-        <div class="loader-wrapper">
-            <div class="loader-ellipsis">
-                <div></div>
-                <div></div>
-                <div></div>
-                <div></div>
-            </div>
-        </div>
-    </div>
-</template>
-
-<script>
-
-export default {
-    name: 'AsyncLoader',
-    props: {
-        loaded: {
-            type: Boolean,
-            default: false
-        }
-    }
-};
-</script>
-
-<style>
-.async-wrapper {
-    position: relative;
-}
-
-.async-wrapper > .deferred {
-    width: 100%;
-    height: 100%;
-    display: none;
-}
-
-.async-wrapper.loaded > .deferred {
-    display: block;
-}
-
-.async-wrapper > .loader-wrapper {
-    display: flex;
-    justify-content: center;
-    align-items: center;
-    position: absolute;
-    top: 0;
-    left: 0;
-    width: 100%;
-    height: 100%;
-}
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis {
-    color: #17a2b8;
-}
-
-.async-wrapper.loaded > .loader-wrapper {
-    display: none;
-}
-
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis,
-.async-wrapper > .loader-wrapper > .loader-ellipsis div {
-    box-sizing: border-box;
-}
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis {
-    display: inline-block;
-    position: relative;
-    width: 80px;
-    height: 80px;
-}
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis div {
-    position: absolute;
-    top: 33.33333px;
-    width: 13.33333px;
-    height: 13.33333px;
-    border-radius: 50%;
-    background: currentColor;
-    animation-timing-function: cubic-bezier(0, 1, 1, 0);
-}
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis div:nth-child(1) {
-    left: 8px;
-    animation: loader-ellipsis1 0.6s infinite;
-}
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis div:nth-child(2) {
-    left: 8px;
-    animation: loader-ellipsis2 0.6s infinite;
-}
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis div:nth-child(3) {
-    left: 32px;
-    animation: loader-ellipsis2 0.6s infinite;
-}
-
-.async-wrapper > .loader-wrapper > .loader-ellipsis div:nth-child(4) {
-    left: 56px;
-    animation: loader-ellipsis3 0.6s infinite;
-}
-
-@keyframes loader-ellipsis1 {
-    0% {
-        transform: scale(0);
-    }
-    100% {
-        transform: scale(1);
-    }
-}
-
-@keyframes loader-ellipsis3 {
-    0% {
-        transform: scale(1);
-    }
-    100% {
-        transform: scale(0);
-    }
-}
-
-@keyframes loader-ellipsis2 {
-    0% {
-        transform: translate(0, 0);
-    }
-    100% {
-        transform: translate(24px, 0);
-    }
-}
-</style>

web/src/components/Navbar.vue

@@ -29,7 +29,16 @@
                 </router-link>
             </li>
         </ul>
-        <SearchBox v-if="hasPermissions" class="mt-1 my-lg-auto my-xl-auto w-100 d-inline mr-1"/>
+        <form class="form-inline mt-1 my-lg-auto my-xl-auto w-100 d-inline mr-1" v-if="hasPermissions">
+            <input
+                class="form-control w-100"
+                type="search"
+                placeholder="Search"
+                aria-label="Search"
+                @input="searchEventItems($event.target.value)"
+                disabled
+            >
+        </form>
         <div class="custom-control-inline mr-1" v-if="hasPermissions">
             <div class="btn-group btn-group-toggle mr-1" v-if="isItemView()">
                 <button :class="['btn', 'btn-info', { active: layout === 'cards' }]" @click="setLayout('cards')">
@@ -94,13 +103,9 @@
 
 <script>
 import {mapState, mapActions, mapMutations, mapGetters} from 'vuex';
-import SearchBox from "@/components/inputs/SearchBox.vue";
 
 export default {
     name: 'Navbar',
-    components: {
-        SearchBox
-    },
     data: () => ({
         views: [
             {'title': 'items', 'path': 'items'},
@@ -117,7 +122,7 @@ export default {
         ...mapGetters(['getEventSlug', 'getActiveView', "checkPermission", "hasPermissions", "layout", "route"]),
     },
     methods: {
-        ...mapActions(['changeEvent', 'changeView']),
+        ...mapActions(['changeEvent', 'changeView', 'searchEventItems']),
         ...mapMutations(['logout']),
         navigateTo(link) {
             if (this.route.path !== link)

web/src/components/Timeline.vue

@@ -40,10 +40,10 @@
                 <div class="">
                     <textarea placeholder="add comment..." v-model="newComment" class="form-control">
                     </textarea>
-                    <AsyncButton class="btn btn-primary float-right" :task="addCommentAndClear">
+                    <button class="btn btn-primary float-right" @click="addCommentAndClear">
                         <font-awesome-icon icon="comment"/>
                         Save Comment
-                    </AsyncButton>
+                    </button>
                 </div>
             </div>
         </li>
@@ -58,10 +58,10 @@
                 <div>
                     <textarea placeholder="reply mail..." v-model="newMail" class="form-control">
                     </textarea>
-                    <AsyncButton class="btn btn-primary float-right" :task="sendMailAndClear">
+                    <button class="btn btn-primary float-right" @click="sendMailAndClear">
                         <font-awesome-icon icon="envelope"/>
                         Send Mail
-                    </AsyncButton>
+                    </button>
                 </div>
             </div>
         </li>
@@ -77,12 +77,11 @@ import {mapActions, mapGetters} from "vuex";
 import TimelineAssignment from "@/components/TimelineAssignment.vue";
 import TimelineRelatedItem from "@/components/TimelineRelatedItem.vue";
 import TimelineShippingVoucher from "@/components/TimelineShippingVoucher.vue";
-import AsyncButton from "@/components/inputs/AsyncButton.vue";
 
 export default {
     name: 'Timeline',
     components: {
-        TimelineShippingVoucher, AsyncButton,
+        TimelineShippingVoucher,
         TimelineRelatedItem, TimelineAssignment, TimelineStateChange, TimelineComment, TimelineMail
     },
     props: {
@@ -104,15 +103,18 @@ export default {
         },
     },
     methods: {
-        ...mapActions(['sendMail', 'postComment']),
+        ...mapActions(['fetchShippingVouchers']),
-        sendMailAndClear: async function () {
+        sendMailAndClear: function () {
-            await this.sendMail(this.newMail);
+            this.$emit('sendMail', this.newMail);
             this.newMail = "";
         },
-        addCommentAndClear: async function () {
+        addCommentAndClear: function () {
-            await this.postComment(this.newComment);
+            this.$emit('addComment', this.newComment);
             this.newComment = "";
         }
+    },
+    mounted() {
+        this.fetchShippingVouchers();
     }
 };
 </script>

web/src/components/inputs/AsyncButton.vue

@@ -1,47 +0,0 @@
-<template>
-    <button @click.stop="handleClick" :disabled="disabled">
-        <span class="spinner-border spinner-border-sm" role="status" aria-hidden="true"
-              :class="{'d-none': !disabled}"></span>
-        <span class="ml-2" :class="{'d-none': !disabled}">In Progress...</span>
-        <span :class="{'d-none': disabled}"><slot></slot></span>
-    </button>
-</template>
-
-<script>
-
-export default {
-    name: 'AsyncButton',
-    data() {
-        return {
-            disabled: false,
-        };
-    },
-    props: {
-        task: {
-            type: Function,
-            required: true,
-        },
-    },
-    methods: {
-        async handleClick() {
-            console.log("AsyncButton.handleClick() called");
-            if (this.task && typeof this.task === 'function') {
-                this.disabled = true;
-                try {
-                    await this.task();
-                } catch (e) {
-                    console.error(e);
-                } finally {
-                    this.disabled = false;
-                }
-            }
-        },
-    }
-};
-</script>
-
-<style scoped>
-.spinner-border {
-    vertical-align: -0.125em;
-}
-</style>

web/src/components/inputs/SearchBox.vue

@@ -1,43 +0,0 @@
-<template>
-    <input
-        class="form-control w-100"
-        type="search"
-        placeholder="Search"
-        aria-label="Search"
-        v-model="search_query"
-        @keyup.enter="dispatchSearch"
-    >
-</template>
-
-<script>
-
-import {mapActions, mapGetters} from "vuex";
-
-export default {
-    name: 'SearchBox',
-    data() {
-        return {
-            search_query: ''
-        }
-    },
-    computed: {
-        ...mapGetters(['getActiveView'])
-    },
-    methods: {
-        ...mapActions(['searchEventItems', 'searchEventTickets']),
-        isItemView() {
-            return this.getActiveView === 'items' || this.getActiveView === 'item';
-        },
-        isTicketView() {
-            return this.getActiveView === 'tickets' || this.getActiveView === 'ticket';
-        },
-        dispatchSearch() {
-            if (this.isItemView()) {
-                this.searchEventItems(this.search_query);
-            } else if (this.isTicketView()) {
-                this.searchEventTickets(this.search_query);
-            }
-        }
-    }
-};
-</script>

web/src/router.js

@@ -7,7 +7,7 @@ import Files from './views/Files';
 import HowTo from './views/HowTo';
 import Login from '@/views/Login.vue';
 import Register from '@/views/Register.vue';
-import Dashboard from "@/views/admin/Dashboard.vue";
+import Debug from "@/views/admin/Debug.vue";
 import Tickets from "@/views/Tickets.vue";
 import Ticket from "@/views/Ticket.vue";
 import Admin from "@/views/admin/Admin.vue";
@@ -59,7 +59,7 @@ const routes = [
                     {requiresAuth: true, requiresPermission: 'delete_event'}
             },
             {
-                path: '', name: 'admin', component: Dashboard, meta:
+                path: '', name: 'admin', component: Debug, meta:
                     {requiresAuth: true, requiresPermission: 'delete_event'}
             },
             {

web/src/store.js

@@ -23,7 +23,6 @@ const store = createStore({
 
         lastEvent: '37C3',
         lastUsed: {},
-        searchQuery: '',
         remember: false,
         user: {
             username: null,
@@ -356,9 +355,10 @@ const store = createStore({
             }
         },
         async searchEventItems({commit, getters, state}, query) {
-            const encoded_query = base64.encode(utf8.encode(query));
+            const foo = utf8.encode(query);
+            const bar = base64.encode(foo);
 
-            const {data, success} = await http.get(`/2/${getters.getEventSlug}/items/${encoded_query}/`, state.user.token);
+            const {data, success} = await http.get(`/2/${getters.getEventSlug}/items/${bar}/`, state.user.token);
             if (data && success)
                 commit('replaceLoadedItems', data);
         },
@@ -407,13 +407,6 @@ const store = createStore({
             if (data && success)
                 commit('replaceTickets', data);
         },
-        async searchEventTickets({commit, getters, state}, query) {
-            const encoded_query = base64.encode(utf8.encode(query));
-
-            const {data, success} = await http.get(`/2/${getters.getEventSlug}/tickets/${encoded_query}/`, state.user.token);
-            if (data && success)
-                commit('replaceTickets', data);
-        },
         async sendMail({commit, dispatch, state}, {id, message}) {
             const {data, success} = await http.post(`/2/tickets/${id}/reply/`, {message}, state.user.token);
             if (data && success) {

web/src/views/Items.vue

@@ -1,82 +1,77 @@
 <template>
-    <AsyncLoader :loaded="loadedItems.length > 0">
+    <div class="container-fluid px-xl-5 mt-3">
-        <div class="container-fluid px-xl-5 mt-3">
+        <Modal title="Edit Item" v-if="editingItem" @close="closeEditingModal()">
-            <Modal title="Edit Item" v-if="editingItem" @close="closeEditingModal()">
+            <template #body>
-                <template #body>
+                <EditItem
-                    <EditItem
+                    :item="editingItem"
-                        :item="editingItem"
+                    badge="uid"
-                        badge="uid"
-                    />
-                </template>
-                <template #buttons>
-                    <button type="button" class="btn btn-secondary" @click="closeEditingModal()">Cancel</button>
-                    <button type="button" class="btn btn-success" @click="saveEditingItem()">Save Changes</button>
-                </template>
-            </Modal>
-            <Lightbox v-if="lightboxHash" :hash="lightboxHash" @close="closeLightboxModal()"/>
-            <div class="row" v-if="layout === 'table'">
-                <div class="col-xl-8 offset-xl-2">
-                    <Table
-                        :columns="['uid', 'description', 'box']"
-                        :items="loadedItems"
-                        :keyName="'uid'"
-                        @itemActivated="openLightboxModalWith($event)"
-                    >
-                        <template #actions="{ item }">
-                            <div class="btn-group">
-                                <button class="btn btn-success"
-                                        @click.stop="confirm('return Item?') && markItemReturned(item)"
-                                        title="returned">
-                                    <font-awesome-icon icon="check"/>
-                                </button>
-                                <button class="btn btn-secondary" @click.stop="openEditingModalWith(item)" title="edit">
-                                    <font-awesome-icon icon="edit"/>
-                                </button>
-                                <button class="btn btn-danger" @click.stop="confirm('delete Item?') && deleteItem(item)"
-                                        title="delete">
-                                    <font-awesome-icon icon="trash"/>
-                                </button>
-                            </div>
-                        </template>
-                    </Table>
-                </div>
-            </div>
-            <Cards
-                v-if="layout === 'cards'"
-                :columns="['uid', 'description', 'box']"
-                :items="loadedItems"
-                :keyName="'uid'"
-                v-slot="{ item }"
-                @itemActivated="openLightboxModalWith($event)"
-            >
-                <AuthenticatedImage v-if="item.file" cached
-                                    :src="`/media/2/256/${item.file}/`"
-                                    class="card-img-top img-fluid"
                 />
-                <div class="card-body">
+            </template>
-                    <h6 class="card-title">{{ item.description }}</h6>
+            <template #buttons>
-                    <h6 class="card-subtitle text-secondary">uid: {{ item.uid }} box: {{ item.box }}</h6>
+                <button type="button" class="btn btn-secondary" @click="closeEditingModal()">Cancel</button>
-                    <div class="row mx-auto mt-2">
+                <button type="button" class="btn btn-success" @click="saveEditingItem()">Save Changes</button>
+            </template>
+        </Modal>
+        <Lightbox v-if="lightboxHash" :hash="lightboxHash" @close="closeLightboxModal()"/>
+        <div class="row" v-if="layout === 'table'">
+            <div class="col-xl-8 offset-xl-2">
+                <Table
+                    :columns="['uid', 'description', 'box']"
+                    :items="loadedItems"
+                    :keyName="'uid'"
+                    @itemActivated="openLightboxModalWith($event)"
+                >
+                    <template #actions="{ item }">
                         <div class="btn-group">
-                            <button class="btn btn-outline-success"
+                            <button class="btn btn-success"
                                     @click.stop="confirm('return Item?') && markItemReturned(item)" title="returned">
                                 <font-awesome-icon icon="check"/>
                             </button>
-                            <button class="btn btn-outline-secondary" @click.stop="openEditingModalWith(item)"
+                            <button class="btn btn-secondary" @click.stop="openEditingModalWith(item)" title="edit">
-                                    title="edit">
                                 <font-awesome-icon icon="edit"/>
                             </button>
-                            <button class="btn btn-outline-danger"
+                            <button class="btn btn-danger" @click.stop="confirm('delete Item?') && deleteItem(item)"
-                                    @click.stop="confirm('delete Item?') && deleteItem(item)"
                                     title="delete">
                                 <font-awesome-icon icon="trash"/>
                             </button>
                         </div>
+                    </template>
+                </Table>
+            </div>
+        </div>
+        <Cards
+            v-if="layout === 'cards'"
+            :columns="['uid', 'description', 'box']"
+            :items="loadedItems"
+            :keyName="'uid'"
+            v-slot="{ item }"
+            @itemActivated="openLightboxModalWith($event)"
+        >
+            <AuthenticatedImage v-if="item.file" cached
+                                :src="`/media/2/256/${item.file}/`"
+                                class="card-img-top img-fluid"
+            />
+            <div class="card-body">
+                <h6 class="card-title">{{ item.description }}</h6>
+                <h6 class="card-subtitle text-secondary">uid: {{ item.uid }} box: {{ item.box }}</h6>
+                <div class="row mx-auto mt-2">
+                    <div class="btn-group">
+                        <button class="btn btn-outline-success"
+                                @click.stop="confirm('return Item?') && markItemReturned(item)" title="returned">
+                            <font-awesome-icon icon="check"/>
+                        </button>
+                        <button class="btn btn-outline-secondary" @click.stop="openEditingModalWith(item)" title="edit">
+                            <font-awesome-icon icon="edit"/>
+                        </button>
+                        <button class="btn btn-outline-danger" @click.stop="confirm('delete Item?') && deleteItem(item)"
+                                title="delete">
+                            <font-awesome-icon icon="trash"/>
+                        </button>
                     </div>
                 </div>
-            </Cards>
+            </div>
-        </div>
+        </Cards>
-    </AsyncLoader>
+    </div>
 </template>
 
 <script>
@@ -87,7 +82,6 @@ import EditItem from '@/components/EditItem';
 import {mapActions, mapGetters, mapState} from 'vuex';
 import Lightbox from '../components/Lightbox';
 import AuthenticatedImage from "@/components/AuthenticatedImage.vue";
-import AsyncLoader from "@/components/AsyncLoader.vue";
 
 export default {
     name: 'Items',
@@ -95,7 +89,7 @@ export default {
         lightboxHash: null,
         editingItem: null,
     }),
-    components: {AsyncLoader, AuthenticatedImage, Lightbox, Table, Cards, Modal, EditItem},
+    components: {AuthenticatedImage, Lightbox, Table, Cards, Modal, EditItem},
     computed: {
         ...mapState(['loadedItems']),
         ...mapGetters(['layout']),

web/src/views/Ticket.vue

@@ -1,92 +1,70 @@
 <template>
-    <AsyncLoader :loaded="ticket.id">
+    <div class="container-fluid px-xl-5 mt-3">
-        <div class="container-fluid px-xl-5 mt-3">
+        <div class="row">
-            <div class="row">
+            <div class="col-xl-8 offset-xl-2">
-                <div class="col-xl-8 offset-xl-2">
+                <div class="card bg-dark text-light mb-2" id="filters">
-                    <div class="card bg-dark text-light mb-2" id="filters">
+                    <div class="card-header">
-                        <div class="card-header">
+                        <h3>Ticket #{{ ticket.id }} - {{ ticket.name }}</h3>
-                            <h3>Ticket #{{ ticket.id }} - {{ ticket.name }}</h3>
+                    </div>
+                    <Timeline :timeline="ticket.timeline" @sendMail="handleMail" @addComment="handleComment"/>
+                    <div class="card-footer d-flex justify-content-between">
+                        <button class="btn btn-secondary mr-2" @click="$router.go(-1)">Back</button>
+                        <!--button class="btn btn-danger" @click="deleteItem({type: 'tickets', id: ticket.id})">
+                            <font-awesome-icon icon="trash"/>
+                            Delete
+                        </button-->
+                        <div class="btn-group">
+                            <select class="form-control" v-model="ticket.assigned_to">
+                                <option v-for="user in users" :value="user.username">{{ user.username }}</option>
+                            </select>
+                            <button class="form-control btn btn-success" @click="assigTicket(ticket)">
+                                Assign&nbsp;Ticket
+                            </button>
                         </div>
-                        <Timeline :timeline="ticket.timeline" @sendMail="handleMail" @addComment="handleComment"/>
+                        <div class="btn-group">
-                        <div class="card-footer d-flex justify-content-between">
+                            <select class="form-control" v-model="ticket.state">
-                            <button class="btn btn-secondary mr-2" @click="$router.go(-1)">Back</button>
+                                <option v-for="status in state_options" :value="status.value">{{ status.text }}</option>
-                            <!--button class="btn btn-danger" @click="deleteItem({type: 'tickets', id: ticket.id})">
+                            </select>
-                                <font-awesome-icon icon="trash"/>
+                            <button class="form-control btn btn-success" @click="changeTicketStatus(ticket)">
-                                Delete
+                                Change&nbsp;Status
-                            </button-->
+                            </button>
-                            <div class="btn-group">
-                                <select class="form-control" v-model="selected_assignee">
-                                    <option v-for="user in users" :value="user.username">{{ user.username }}</option>
-                                </select>
-                                <button class="form-control btn btn-success"
-                                        @click="assignTicket(ticket)"
-                                        :disabled="!selected_assignee || (selected_assignee == ticket.assigned_to)">
-                                    Assign&nbsp;Ticket
-                                </button>
-                            </div>
-                            <div class="btn-group">
-                                <select class="form-control" v-model="selected_state">
-                                    <option v-for="status in state_options" :value="status.value">{{
-                                            status.text
-                                        }}
-                                    </option>
-                                </select>
-                                <button class="form-control btn btn-success"
-                                        @click="changeTicketStatus(ticket)"
-                                        :disabled="(selected_state == ticket.state)">
-                                    Change&nbsp;Status
-                                </button>
-                            </div>
                         </div>
-                        <div class="card-footer d-flex justify-content-between">
+                    </div>
-                            <ClipboardButton :payload="shippingEmail" class="btn btn-primary">
+                    <div class="card-footer d-flex justify-content-between">
-                                <font-awesome-icon icon="clipboard"/>
+                        <ClipboardButton :payload="shippingEmail" class="btn btn-primary">
-                                Copy&nbsp;DHL&nbsp;contact&nbsp;to&nbsp;clipboard
+                            <font-awesome-icon icon="clipboard"/>
-                            </ClipboardButton>
+                            Copy&nbsp;DHL&nbsp;contact&nbsp;to&nbsp;clipboard
-                            <div class="btn-group">
+                        </ClipboardButton>
-                                <select class="form-control" v-model="shipping_voucher_type">
+                        <div class="btn-group">
-                                    <option v-for="type in availableShippingVoucherTypes.filter(t=>t.count>0)"
+                            <select class="form-control" v-model="shipping_voucher_type">
-                                            :value="type.id">{{ type.name }}
+                                <option v-for="type in availableShippingVoucherTypes.filter(t=>t.count>0)"
-                                    </option>
+                                        :value="type.id">{{ type.name }}
-                                </select>
+                                </option>
-                                <button class="form-control btn btn-success"
+                            </select>
-                                        @click="claimShippingVoucher({ticket: ticket.id, shipping_voucher_type}).then(()=>shipping_voucher_type=null)"
+                            <button class="form-control btn btn-success"
-                                        :disabled="!shipping_voucher_type">
+                                    @click="claimShippingVoucher({ticket: ticket.id, shipping_voucher_type}).then(()=>shipping_voucher_type=null)"
-                                    Claim&nbsp;Shipping&nbsp;Voucher
+                                    :disabled="!shipping_voucher_type">
-                                </button>
+                                Claim&nbsp;Shipping&nbsp;Voucher
-                            </div>
+                            </button>
                         </div>
                     </div>
                 </div>
             </div>
         </div>
-    </AsyncLoader>
+    </div>
 </template>
 
 <script>
 import {mapActions, mapGetters, mapState} from 'vuex';
 import Timeline from "@/components/Timeline.vue";
 import ClipboardButton from "@/components/inputs/ClipboardButton.vue";
-import AsyncLoader from "@/components/AsyncLoader.vue";
 
 export default {
     name: 'Ticket',
-    components: {AsyncLoader, ClipboardButton, Timeline},
+    components: {ClipboardButton, Timeline},
     data() {
         return {
-            selected_state: null,
+            shipping_voucher_type: null
-            selected_assignee: null,
-            shipping_voucher_type: null,
-        }
-    },
-    watch: {
-        ticket(val) {
-            if (this.selected_state == null) {
-                this.selected_state = val.state;
-            }
-            if (this.selected_assignee == null) {
-                this.selected_assignee = val.assigned_to
-            }
         }
     },
     computed: {
@@ -105,7 +83,7 @@ export default {
     methods: {
         ...mapActions(['deleteItem', 'markItemReturned', 'sendMail', 'updateTicketPartial', 'postComment']),
         ...mapActions(['loadTickets', 'fetchTicketStates', 'loadUsers', 'scheduleAfterInit']),
-        ...mapActions(['claimShippingVoucher', 'fetchShippingVouchers']),
+        ...mapActions(['claimShippingVoucher']),
         handleMail(mail) {
             this.sendMail({
                 id: this.ticket.id,
@@ -119,23 +97,20 @@ export default {
             })
         },
         changeTicketStatus(ticket) {
-            ticket.state = this.selected_state;
             this.updateTicketPartial({
                 id: ticket.id,
-                state: this.selected_state,
+                state: ticket.state
             })
         },
-        assignTicket(ticket) {
+        assigTicket(ticket) {
-            ticket.assigned_to = this.selected_assignee;
             this.updateTicketPartial({
                 id: ticket.id,
-                assigned_to: this.selected_assignee
+                assigned_to: ticket.assigned_to
             })
         },
     },
     mounted() {
-        this.scheduleAfterInit(() => [this.fetchTicketStates(), this.loadTickets(), this.loadUsers(),
+        this.scheduleAfterInit(() => [this.fetchTicketStates(), this.loadTickets(), this.loadUsers()]);
-            this.fetchShippingVouchers()]);
     }
 };
 </script>

web/src/views/Tickets.vue

@@ -1,53 +1,51 @@
 <template>
-    <AsyncLoader :loaded="tickets.length > 0">
+    <div class="container-fluid px-xl-5 mt-3">
-        <div class="container-fluid px-xl-5 mt-3">
+        <div class="row">
-            <div class="row">
+            <div class="col-xl-8 offset-xl-2">
-                <div class="col-xl-8 offset-xl-2">
+                <Table
-                    <Table
+                    :columns="['id', 'name', 'state', 'last_activity', 'assigned_to']"
-                        :columns="['id', 'name', 'state', 'last_activity', 'assigned_to', 'actions', 'actions2']"
+                    :items="tickets"
-                        :items="tickets.map(formatTicket)"
+                    :keyName="'id'"
-                        :keyName="'id'"
+                    v-if="layout === 'table'"
-                        v-if="layout === 'table'"
+                >
-                    >
+                    <template #actions="{ item }">
-                        <template v-slot:actions="{item}">
+                        <div class="btn-group">
-                            <div class="btn-group">
+                            <a class="btn btn-primary" :href="'/'+ getEventSlug + '/ticket/' + item.id" title="view"
-                                <a class="btn btn-primary" :href="'/'+ getEventSlug + '/ticket/' + item.id" title="view"
+                               @click.prevent="gotoDetail(item)">
-                                   @click.prevent="gotoDetail(item)">
+                                <font-awesome-icon icon="eye"/>
-                                    <font-awesome-icon icon="eye"/>
+                                View
-                                    View
+                            </a>
-                                </a>
+                        </div>
-                            </div>
+                    </template>
-                        </template>
+                </Table>
-                    </Table>
-                </div>
             </div>
-            <CollapsableCards v-if="layout === 'tasks'" :items="tickets"
-                              :columns="['id', 'name', 'last_activity', 'assigned_to']"
-                              :keyName="'state'" :sections="['pending_new', 'pending_open','pending_shipping',
-                          'pending_physical_confirmation','pending_return','pending_postponed'].map(stateInfo)">
-                <template #section_header="{index, section, count}">
-                    {{ section.text }} <span class="badge badge-light ml-1">{{ count }}</span>
-                </template>
-                <template #section_body="{item}">
-                    <tr>
-                        <td>{{ item.id }}</td>
-                        <td>{{ item.name }}</td>
-                        <td>{{ item.last_activity }}</td>
-                        <td>{{ item.assigned_to }}</td>
-                        <td>
-                            <div class="btn-group">
-                                <a class="btn btn-primary" :href="'/'+ getEventSlug + '/ticket/' + item.id" title="view"
-                                   @click.prevent="gotoDetail(item)">
-                                    <font-awesome-icon icon="eye"/>
-                                    View
-                                </a>
-                            </div>
-                        </td>
-                    </tr>
-                </template>
-            </CollapsableCards>
         </div>
-    </AsyncLoader>
+        <CollapsableCards v-if="layout === 'tasks'" :items="tickets"
+                          :columns="['id', 'name', 'last_activity', 'assigned_to']"
+                          :keyName="'state'" :sections="['pending_new', 'pending_open','pending_shipping',
+                          'pending_physical_confirmation','pending_return','pending_postponed'].map(stateInfo)">
+            <template #section_header="{index, section, count}">
+                {{ section.text }} <span class="badge badge-light ml-1">{{ count }}</span>
+            </template>
+            <template #section_body="{item}">
+                <tr>
+                    <td>{{ item.id }}</td>
+                    <td>{{ item.name }}</td>
+                    <td>{{ item.last_activity }}</td>
+                    <td>{{ item.assigned_to }}</td>
+                    <td>
+                        <div class="btn-group">
+                            <a class="btn btn-primary" :href="'/'+ getEventSlug + '/ticket/' + item.id" title="view"
+                               @click.prevent="gotoDetail(item)">
+                                <font-awesome-icon icon="eye"/>
+                                View
+                            </a>
+                        </div>
+                    </td>
+                </tr>
+            </template>
+        </CollapsableCards>
+    </div>
 </template>
 
 <script>
@@ -58,11 +56,10 @@ import {mapActions, mapGetters, mapState} from 'vuex';
 import Lightbox from '../components/Lightbox';
 import Table from '@/components/Table';
 import CollapsableCards from "@/components/CollapsableCards.vue";
-import AsyncLoader from "@/components/AsyncLoader.vue";
 
 export default {
     name: 'Tickets',
-    components: {AsyncLoader, Lightbox, Table, Cards, Modal, EditItem, CollapsableCards},
+    components: {Lightbox, Table, Cards, Modal, EditItem, CollapsableCards},
     computed: {
         ...mapState(['tickets']),
         ...mapGetters(['stateInfo', 'getEventSlug', 'layout']),

web/src/views/admin/Dashboard.vue

@@ -1,33 +0,0 @@
-<template>
-    <div>
-        <h3 class="text-center">Events</h3>
-        <ul>
-            <li v-for="event in events" :key="event.id">
-                {{ event.slug }}
-            </li>
-        </ul>
-    </div>
-</template>
-
-<script>
-import {mapActions, mapState} from 'vuex';
-import Table from '@/components/Table';
-
-export default {
-    name: 'Dashboard',
-    components: {},
-    computed: {
-        ...mapState(['events']),
-    },
-    methods: {
-        ...mapActions(['loadEvents']),
-
-    },
-    mounted() {
-        this.loadEvents();
-    }
-};
-</script>
-
-<style>
-</style>

web/src/views/admin/Debug.vue

@@ -0,0 +1,62 @@
+<template>
+    <div>
+    <!--qr-code :text="qr_url" color="#000" bg-color="#fff" error-level="H" class="qr-code"></qr-code-->
+    <h3 class="text-center">Events</h3>
+    <!--p>{{ events }}</p-->
+    <ul>
+        <li v-for="event in events" :key="event.id">
+            {{ event.slug }}
+        </li>
+    </ul>
+    <h3 class="text-center">Items</h3>
+    <!--p>{{ loadedItems }}</p-->
+    <ul>
+        <li v-for="item in loadedItems" :key="item.id">
+            {{ item.description }}
+        </li>
+    </ul>
+    <h3 class="text-center">Boxes</h3>
+    <!--p>{{ loadedBoxes }}</p-->
+    <ul>
+        <li v-for="box in loadedBoxes" :key="box.id">
+            {{ box.name }}
+        </li>
+    </ul>
+    <h3 class="text-center">Issues</h3>
+    <!--p>{{ issues }}</p-->
+    <ul>
+        <li v-for="issue in tickets" :key="issue.id">
+            {{ issue.id }}
+        </li>
+    </ul>
+    </div>
+</template>
+
+<script>
+import {mapActions, mapState} from 'vuex';
+import Table from '@/components/Table';
+
+export default {
+    name: 'Debug',
+    components: {Table},
+    computed: {
+        ...mapState(['events', 'loadedItems', 'loadedBoxes', 'tickets']),
+        qr_url() {
+            return window.location.href;
+        }
+    },
+    methods: {
+        ...mapActions(['changeEvent', 'loadTickets']),
+
+    },
+    mounted() {
+        this.loadTickets();
+    }
+};
+</script>
+
+<style>
+.qr-code img {
+    border: #fff solid 7px
+}
+</style>