added a check in the make_reply function to ensure that mails have a body

core/mail/protocol.py

@@ -93,11 +93,11 @@ def make_reply(reply_email, references=None, event=None):
         reply_email.save()
     if references:
         reply["References"] = " ".join(references)
-
-    reply.set_content(reply_email.body)
-
-    return reply
-
+    if reply_email.body != "":
+        reply.set_content(reply_email.body)
+        return reply
+    else:
+        raise SpecialMailException("mail content emty")
 
 async def send_smtp(message):
     await aiosmtplib.send(message, hostname="127.0.0.1", port=25, use_tls=False, start_tls=False)
@@ -303,10 +303,10 @@ class LMTPHandler:
             systemevent = await database_sync_to_async(SystemEvent.objects.create)(type='email received',
                                                                                    reference=email.id)
             log.info(f"Created system event {systemevent.id}")
-            channel_layer = get_channel_layer()
-            await channel_layer.group_send(
-                'general', {"type": "generic.event", "name": "send_message_to_frontend", "event_id": systemevent.id,
-                            "message": "email received"})
+            #channel_layer = get_channel_layer()
+            #await channel_layer.group_send(
+            #    'general', {"type": "generic.event", "name": "send_message_to_frontend", "event_id": systemevent.id,
+            #                "message": "email received"})
             log.info(f"Sent message to frontend")
             if new and reply:
                 log.info('Sending message to %s' % reply['To'])

core/tickets/api_v2.py

@@ -102,12 +102,6 @@ def manual_ticket(request, event_slug):
         subject=request.data['name'],
         body=request.data['body'],
     )
-    systemevent = SystemEvent.objects.create(type='email received', reference=email.id)
-    channel_layer = get_channel_layer()
-    async_to_sync(channel_layer.group_send)(
-        'general', {"type": "generic.event", "name": "send_message_to_frontend", "event_id": systemevent.id,
-                    "message": "email received"}
-    )
 
     return Response(IssueSerializer(issue).data, status=status.HTTP_201_CREATED)
 
@@ -133,12 +127,6 @@ def add_comment(request, pk):
         issue_thread=issue,
         comment=request.data['comment'],
     )
-    systemevent = SystemEvent.objects.create(type='comment added', reference=comment.id)
-    channel_layer = get_channel_layer()
-    async_to_sync(channel_layer.group_send)(
-        'general', {"type": "generic.event", "name": "send_message_to_frontend", "event_id": systemevent.id,
-                    "message": "comment added"}
-    )
     return Response(CommentSerializer(comment).data, status=status.HTTP_201_CREATED)
 
 

deploy/dev/docker-compose.yml

@@ -7,6 +7,7 @@ services:
     environment:
       - HTTP_HOST=core
       - DB_FILE=dev.db
+      - DEBUG_MODE_ACTIVE=true
     volumes:
       - ../../core:/code
       - ../testdata.py:/code/testdata.py