From 1b9ed638918d0a1394224387b139450dd9b153cb Mon Sep 17 00:00:00 2001
From: jedi <git@m.j3d1.de>
Date: Wed, 8 Jan 2025 23:23:38 +0100
Subject: [PATCH] fix bug in tickets search api and add tests

---
 core/tickets/api_v2.py                | 12 ++++-
 core/tickets/serializers.py           |  2 +-
 core/tickets/tests/v2/test_tickets.py | 74 ++++++++++++++++++++++++++-
 3 files changed, 84 insertions(+), 4 deletions(-)

diff --git a/core/tickets/api_v2.py b/core/tickets/api_v2.py
index 99dc008..d2a443a 100644
--- a/core/tickets/api_v2.py
+++ b/core/tickets/api_v2.py
@@ -147,8 +147,18 @@ def filter_issues(issues, query):
     for issue in issues:
         value = 0
         for token in query_tokens:
-            if token in issue.description:
+            if token in issue.name:
                 value += 1
+        for comment in issue.comments.all():
+            for token in query_tokens:
+                if token in comment.comment:
+                    value += 1
+        for email in issue.emails.all():
+            for token in query_tokens:
+                if token in email.subject:
+                    value += 1
+                if token in email.body:
+                    value += 1
         if value > 0:
             yield {'search_score': value, 'issue': issue}
 
diff --git a/core/tickets/serializers.py b/core/tickets/serializers.py
index 50cdb72..9c915c8 100644
--- a/core/tickets/serializers.py
+++ b/core/tickets/serializers.py
@@ -142,7 +142,7 @@ class SearchResultSerializer(serializers.Serializer):
     item = IssueSerializer()
 
     def to_representation(self, instance):
-        return {**IssueSerializer(instance['item']).data, 'search_score': instance['search_score']}
+        return {**IssueSerializer(instance['issue']).data, 'search_score': instance['search_score']}
 
     class Meta:
         model = IssueThread
diff --git a/core/tickets/tests/v2/test_tickets.py b/core/tickets/tests/v2/test_tickets.py
index 9720625..0a5e6cc 100644
--- a/core/tickets/tests/v2/test_tickets.py
+++ b/core/tickets/tests/v2/test_tickets.py
@@ -383,15 +383,85 @@ class IssueSearchTest(TestCase):
 
     def setUp(self):
         super().setUp()
-        self.event = Event.objects.create(slug='EVENT', name='Event')
         self.user = ExtendedUser.objects.create_user('testuser', 'test', 'test')
         self.user.user_permissions.add(*Permission.objects.all())
         self.user.save()
+        self.event = Event.objects.create(slug='EVENT', name='Event')
+        self.box = Container.objects.create(name='box1')
+        self.item = Item.objects.create(container=self.box, description="foo", event=self.event)
         self.token = AuthToken.objects.create(user=self.user)
         self.client = Client(headers={'Authorization': 'Token ' + self.token[1]})
 
-    def test_search(self):
+    def test_search_empty_result(self):
         search_query = b64encode(b'abc').decode('utf-8')
         response = self.client.get(f'/api/2/{self.event.slug}/tickets/{search_query}/')
         self.assertEqual(200, response.status_code)
         self.assertEqual([], response.json())
+
+    def test_search(self):
+        now = datetime.now()
+        issue = IssueThread.objects.create(
+            name="test issue abc",
+            event=self.event,
+        )
+        mail1 = Email.objects.create(
+            subject='test',
+            body='test abc',
+            sender='test',
+            recipient='test',
+            issue_thread=issue,
+            timestamp=now,
+        )
+        mail2 = Email.objects.create(
+            subject='test',
+            body='test',
+            sender='test',
+            recipient='test',
+            issue_thread=issue,
+            in_reply_to=mail1.reference,
+            timestamp=now + timedelta(seconds=2),
+        )
+        assignment = Assignment.objects.create(
+            issue_thread=issue,
+            assigned_to=self.user,
+            timestamp=now + timedelta(seconds=3),
+        )
+        comment = Comment.objects.create(
+            issue_thread=issue,
+            comment="test def",
+            timestamp=now + timedelta(seconds=4),
+        )
+        match = ItemRelation.objects.create(
+            issue_thread=issue,
+            item=self.item,
+            timestamp=now + timedelta(seconds=5),
+        )
+        search_query = b64encode(b'abc').decode('utf-8')
+        response = self.client.get(f'/api/2/{self.event.slug}/tickets/{search_query}/')
+        self.assertEqual(200, response.status_code)
+        self.assertEqual(1, len(response.json()))
+        self.assertEqual(issue.id, response.json()[0]['id'])
+        score2 = response.json()[0]['search_score']
+
+        search_query = b64encode(b'def').decode('utf-8')
+        response = self.client.get(f'/api/2/{self.event.slug}/tickets/{search_query}/')
+        self.assertEqual(200, response.status_code)
+        self.assertEqual(1, len(response.json()))
+        self.assertEqual(issue.id, response.json()[0]['id'])
+        score1 = response.json()[0]['search_score']
+
+        search_query = b64encode(b'ghi').decode('utf-8')
+        response = self.client.get(f'/api/2/{self.event.slug}/tickets/{search_query}/')
+        self.assertEqual(200, response.status_code)
+        self.assertEqual(0, len(response.json()))
+
+        search_query = b64encode(b'abc def').decode('utf-8')
+        response = self.client.get(f'/api/2/{self.event.slug}/tickets/{search_query}/')
+        self.assertEqual(200, response.status_code)
+        self.assertEqual(1, len(response.json()))
+        self.assertEqual(issue.id, response.json()[0]['id'])
+        score3 = response.json()[0]['search_score']
+
+        self.assertGreater(score3, score2)
+        self.assertGreater(score2, score1)
+        self.assertGreater(score1, 0)